From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757948AbbKSHil (ORCPT ); Thu, 19 Nov 2015 02:38:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:59109 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbKSHij (ORCPT ); Thu, 19 Nov 2015 02:38:39 -0500 Subject: Re: [PATCH 04/71] ncr5380: Remove more pointless macros To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20151118083455.331768508@telegraphics.com.au> <20151118083456.362586813@telegraphics.com.au> From: Hannes Reinecke Message-ID: <564D7C7C.4080002@suse.de> Date: Thu, 19 Nov 2015 08:38:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151118083456.362586813@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 09:34 AM, Finn Thain wrote: > ASM macro is never defined. rtrc in pas16.c is not used. > NCR5380_map_config, do_NCR5380_intr, do_t128_intr and do_pas16_intr > are unused. NCR_NOT_SET harms readability. Remove them. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.h | 3 --- > drivers/scsi/g_NCR5380.c | 29 ++++++++++++++--------------- > drivers/scsi/g_NCR5380.h | 5 ----- > drivers/scsi/pas16.c | 16 ---------------- > drivers/scsi/pas16.h | 5 ----- > drivers/scsi/t128.h | 4 ---- > 6 files changed, 14 insertions(+), 48 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)