From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934348AbbKSORC (ORCPT ); Thu, 19 Nov 2015 09:17:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:57623 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbbKSORA (ORCPT ); Thu, 19 Nov 2015 09:17:00 -0500 Message-ID: <564DD9DA.7000702@suse.de> Date: Thu, 19 Nov 2015 15:16:58 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/71] ncr5380: Proceed with next command after NCR5380_select() calls scsi_done References: <20151118083455.331768508@telegraphics.com.au> <20151118083459.541713432@telegraphics.com.au> In-Reply-To: <20151118083459.541713432@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 09:35 AM, Finn Thain wrote: > If a target disappears from the SCSI bus, NCR5380_select() may > subsequently fail with a time-out. In this situation, scsi_done is > called and NCR5380_select() returns 0. Both hostdata->connected and > hostdata->selecting are NULL and the main loop should proceed with > the next command in the issue queue. Clarify this logic. > > Signed-off-by: Finn Thain > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)