From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937533AbdAEAyw (ORCPT ); Wed, 4 Jan 2017 19:54:52 -0500 Received: from mga06.intel.com ([134.134.136.31]:7673 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937522AbdAEAyq (ORCPT ); Wed, 4 Jan 2017 19:54:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,318,1477983600"; d="scan'208";a="1108110970" Subject: Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks To: Andy Shevchenko References: <1481306510-7471-1-git-send-email-irina.tirdea@intel.com> <1481306510-7471-2-git-send-email-irina.tirdea@intel.com> <20161213232524.GQ5423@codeaurora.org> <32235fb3-0d54-211d-28f4-4655e4bc7812@linux.intel.com> <20161217013337.GW5423@codeaurora.org> <7f3d03dc-24fe-ec3f-4a3b-926c28f0ac86@linux.intel.com> <20161221230557.GK5423@codeaurora.org> Cc: ALSA Development Mailing List , Len Brown , Irina Tirdea , "Rafael J. Wysocki" , Michael Turquette , "x86@kernel.org" , Stephen Boyd , "linux-kernel@vger.kernel.org" , Takashi Iwai , "linux-acpi@vger.kernel.org" , Ingo Molnar , Mark Brown , "H. Peter Anvin" , Darren Hart , Thomas Gleixner , platform-driver-x86@vger.kernel.org, linux-clk@vger.kernel.org, Pierre-Louis Bossart From: Pierre-Louis Bossart Message-ID: <564d1f26-dd11-d237-7e63-87287a062c03@linux.intel.com> Date: Wed, 4 Jan 2017 18:54:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> this convention is suggested: >>>> PLT_CLK[2:0] - Camera >>>> PLT_CLK[3] - Audio Codec >>>> PLT_CLK[4] - >>>> PLT_CLK[5] - COMMs > By the way, would I suggest to use same prefix as provider, i.e. > pmc_atom_plt_clk_%d ? I tried this suggestion and it doesn't work unfortunately. It looks like the struct clk_lookup_alloc is limited to 16 chars for the connector_id. "pmc_a_plt_clk_" works but that's not really helping. The suggestion would also require a patch on the audio side since the use of pmc_plt_clk_3 was already merged. -> no change.