mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Jiri Slaby" <jslaby@suse.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"Peter Hurley" <peter@hurleysoftware.com>,
	linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"PA20 TOM TSAI 蔡宗佑" <tom_tsai@fintek.com.tw>,
	"Peter H" <peter_hong@fintek.com.tw>,
	"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 4/7] serial: 8250_fintek: Rearrange function
Date: Tue, 6 Sep 2016 09:56:19 +0800	[thread overview]
Message-ID: <564d5aa9-6cde-2bac-afe2-39956caa93f7@gmail.com> (raw)
In-Reply-To: <CAPybu_09HrXc2p+KzqRwcJKGDFCgNv5gMtNYK5Fx4SoJ2gMC3Q@mail.gmail.com>

Hi Ricardo, Greg,

Ricardo Ribalda Delgado 於 2016/9/1 下午 07:17 寫道:
> On one previous patch you almost rewrote theset_irq_mode function and
> added the prototype. It might be a good moment to move the whole
> function up.
>

I had try with merge the following 2 patches in local,
  1: serial: 8250_fintek: Set IRQ Mode when port probed
  2: serial: 8250_fintek: Rearrange function

but it made the patch less readable. So I'll try to add
set_irq() with prototype first, and change this function location
with other patch.

Could you give me some comments, Greg? Should I merge it?

Thanks
-- 
With Best Regards,
Peter Hong

  reply	other threads:[~2016-09-06  1:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  3:39 [PATCH 0/7] serial: 8250_fintek: Fix the IRQ mode and code refactoring Ji-Ze Hong (Peter Hong)
2016-09-01  3:39 ` [PATCH 1/7] serial: 8250_fintek: Refactoring read/write method Ji-Ze Hong (Peter Hong)
2016-09-01  3:39 ` [PATCH 2/7] serial: 8250_fintek: Set IRQ Mode when port probed Ji-Ze Hong (Peter Hong)
2016-09-01  3:39 ` [PATCH 3/7] serial: 8250_fintek: Set maximum FIFO of F81216H Ji-Ze Hong (Peter Hong)
2016-09-01 11:16   ` Ricardo Ribalda Delgado
2016-09-06  1:37     ` Ji-Ze Hong (Peter Hong)
2016-09-01  3:39 ` [PATCH 4/7] serial: 8250_fintek: Rearrange function Ji-Ze Hong (Peter Hong)
2016-09-01 11:17   ` Ricardo Ribalda Delgado
2016-09-06  1:56     ` Ji-Ze Hong (Peter Hong) [this message]
2016-09-01  3:39 ` [PATCH 5/7] serial: 8250_fintek: Add F81216 Support Ji-Ze Hong (Peter Hong)
2016-09-01 11:22   ` Ricardo Ribalda Delgado
2016-09-06  2:04     ` Ji-Ze Hong (Peter Hong)
2016-09-01  3:39 ` [PATCH 6/7] serial: 8250_fintek: Add F81866 Support Ji-Ze Hong (Peter Hong)
2016-09-01  3:39 ` [PATCH 7/7] serial: 8250_fintek: Add F81865 Support Ji-Ze Hong (Peter Hong)
2016-09-01 11:29   ` Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564d5aa9-6cde-2bac-afe2-39956caa93f7@gmail.com \
    --to=hpeter@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=peter_hong@fintek.com.tw \
    --cc=ricardo.ribalda@gmail.com \
    --cc=tom_tsai@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome