From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B621146AA70 for ; Tue, 21 Jul 2026 15:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784648189; cv=none; b=qHkxWMjJZcD8EW9sOrDNCHm2PhOpP6Ae58HPiiv0RZmDQkdOWZvdO8bn4xwrkPxoV8DZXVlXCnHeKkiQwiWd8l+Cw5dSAUyhmSyVBWJycRZmgxhNNrL7TcTezaumOkmiDHEi27GlStUoLzFp0++7jYe0kIHTdHrzU+RXiV6Cuaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784648189; c=relaxed/simple; bh=90ilvZ2uiFj9soGCmmuJZKFMtDRxEs3Q4N75AtPX8GY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FehKgsDKPaD/TC6amDUMIzqLHqZtJ87jSFtKxayF5FobDbTw6L+7O2NSlRU3tuxOZYf2VhvEcZryGsqU6NEQGJJ7JFayAtM8+1ultj3zzllbTkCmjTXvWRdsIfTVl18ThLylpILXUDkIM58Ue/R3MJtD6fl2VYztp3Uc7pej+28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=So5SFAed; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L9lNsSZ3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="So5SFAed"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L9lNsSZ3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDgG7B1399806 for ; Tue, 21 Jul 2026 15:36:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 37qO0VWco0TU7hswZfa/wttTjRFPaqqUvt6iWLk1rxU=; b=So5SFAedodumVxkp eBfkKf30+4/LIArfN8wbHOQpb844CD+UT/rejDl5cZ5sKqbZ0UL3D0+q+IcNzuZa zESvRy/4PEAXtmUTpfXX6kmHjqX2fcgu4BE58HJthQ8oZXXxhvc7EszHJeberStz 7hWHZjmm0iC2sNYImTdpAj43nimm/Ki9vs7wSsWFneCPXFfKOrdKGIUmxLxF2ZQe zi/1xbk6rWtfdArwUWI0Xo2DFd2GRHUsOCv1RfhRQRJ1oo1twjcvRDh2V1yZDRr6 Kh9qwj+y5JoGaTCjXlmeBXvyptUAmscBlUspwEuf9GjL0v7Gp0haCUHMNYiQ8J1u EZOVSg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1es3721-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 15:36:27 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c9e97b626so21972071cf.1 for ; Tue, 21 Jul 2026 08:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784648187; x=1785252987; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=37qO0VWco0TU7hswZfa/wttTjRFPaqqUvt6iWLk1rxU=; b=L9lNsSZ3e66F/dt/pQXkMYjYvu8GU3/tku+pVXQHBSphrCMOVM2EChFaj4O6wutwTa beMggsi4JenJqrtXZiKAiR9P4J9BrH4WqA0de35AZdyGParzd2HFh7sUcAsC0He4v6Zq 5i2CWbCVb+XKgpBpZsFamtww2quaxywayicN6bGdKMJPXBs4OyVmnDKD7hC04p8kJrrc HDIi9ugEA0896jl2IGJkkKb/Ge95gaBTdx7qU4yYw7D/aM2APZM+b4j46yHgNz6G9WfH KjkGBF74KD0IFE52e86GVboKpypH9Pq2l8L00cmJxExvpXgoRRH3/sVkhbmQ+JQnc2V+ Prow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784648187; x=1785252987; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=37qO0VWco0TU7hswZfa/wttTjRFPaqqUvt6iWLk1rxU=; b=jJW0ZZJRWYJ33IvCpxbg+u4JyP9bbf428MnfgZfDxHq1Ybwx/Psq/9VH1nWcL4JUXM gcdpx2lOCflUSMFO58OKODD8t6KH4joZ7wNaeEk6odnVYoUlKMY7yPzkOL6Rucla8mJC KVqUKcMZNfSkk/kISQgfyCu5sKM/d71/7pFhXykNzFNgiaTEni8cdv8PwE5RxOmnQX+7 KSmqfY/tJ6YyIS8SVrw2RS04DDY/Py3dSkVzhhNcj07zgGSfgZbeC1PCfrUUpXDRiWT3 ntdU93/FTHS/2O3xD0yieDw9xWA9BNU3dtqYt+aa/M/dcBN6ZJx18rETK22DhBlc1We9 lLZw== X-Forwarded-Encrypted: i=1; AHgh+Rp39ezJ2cTIFFN+UQtbOBurwOp2FYa8lMBqTlk2fgVuLVXxXve0Qhp/DTy5El4ToRtERQh1CSRzV7i7mRc=@vger.kernel.org X-Gm-Message-State: AOJu0YwBBDziWvETNVtEsNwwKas47h6uc2FtFQivVwrBPIeXQWKBzifK 9uQX7xfkWD6S6G+h4pDZFB9sbNhNWfDTGFiNq3nFEo4z/1jnfTRqpymWWCl6p+eWKyumR78RZSU O84q0i9shFMFwt0hGyuETf4MWl4wI0zqPJ2QoRnqqeajJOX5MESlZgvAXGzK2lRVu9Kw= X-Gm-Gg: AfdE7clbgwDg5L33Va5dwVYX8F83hmXnRkRL/o10RkTK3WJSwMUz7euzw2jzeRB/7br r9mNaPhHr6L2noh6YdaMTQmZPLqVPbiLk/d87zDjdiJJ3U2J/Ypsc4IxI3dBu1TdsAu6QTiF2IC 95gFxCD4Nv7N0DOJqUjry4u6nOYOGnJGmfSGqimQ+fBZfmegtW/3sCOHI7ScorGOOm/1E9yk39D kJ8DQMANlpGE5YY+s/8QQggpN3h4ZBDUk73dHAzI7hfVAQtifwn9oyL5t9YNaH1eCcM5AofLMv7 mezVnt0QlYw+oZ6Spnot+p1aHzNlaBMkscOKwRmetrDRTRCiMMoZUPi3I4jdoq+8r60raFbye+t AcJ2wxJqvjMmorxtEtfmcMpdC X-Received: by 2002:ac8:5e4c:0:b0:51c:8fb:fa46 with SMTP id d75a77b69052e-52674a27727mr31140341cf.9.1784648187012; Tue, 21 Jul 2026 08:36:27 -0700 (PDT) X-Received: by 2002:ac8:5e4c:0:b0:51c:8fb:fa46 with SMTP id d75a77b69052e-52674a27727mr31140081cf.9.1784648186562; Tue, 21 Jul 2026 08:36:26 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c17009ae04bsm607287866b.8.2026.07.21.08.36.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 08:36:25 -0700 (PDT) Message-ID: <56522c76-389b-486b-ac64-ded7745f512f@oss.qualcomm.com> Date: Tue, 21 Jul 2026 17:36:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: ipq5210: Enable USB and PCIe on RDP504 To: Varadarajan Narayanan , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260715-08-dts-v2-0-b060b68e0256@oss.qualcomm.com> <20260715-08-dts-v2-2-b060b68e0256@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260715-08-dts-v2-2-b060b68e0256@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SPZykuvH c=1 sm=1 tr=0 ts=6a5f91fb cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=ZVc07XdHWGtlc-ISXKAA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: tJPs0hKaYE-eXdfR-ADZdlfIIKdkiTuF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE2NSBTYWx0ZWRfX5WOVr9XtKg1r uOXUMZHvcVBdes8YqpeeEsW2j9LXIG3NdocjwAXI+2lYh5DMsFpteL0ace4+lCQGLEXxmQDCs3G isyEzNvsIAXYfcxxGnOwwKIlwEhZ2Crot/6qkjj15GDVMz3Wuehjc7grkyAN/NMUFDzxcm3YQPk 1x1bbs7xcsDNAJUYvZtNeYnqCERYdkMl8KtDUubhSFdq3UuIJ4uv5o4e9tllsVwlKu4L6hjYFIw koS3v0iZMcVBMUqlM6NIBek8LE8CKAm5mzPKJrfwasvqBf9+1socdFSSUbhlNKqUqisH//VK+mR L99vjEPbJ1Em5hlrKnFWiTg6pH1MPwFzxyozhyOiMNfkqwFTRN/FGCQ80yO8s/ReD0QHsKHBFi8 8mWaKg/MEfuB8+iWs8hESKJUr6v/iYpEYXHr823zc2RBrnscpUChAfA9ES1wpNtZJAH1dBJWnQI Q5YvC2F62ehTLYs+4uw== X-Proofpoint-ORIG-GUID: tJPs0hKaYE-eXdfR-ADZdlfIIKdkiTuF X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE2NSBTYWx0ZWRfX3bYVXBJQWPjd xNxxL76W9qABR57Fe41tkSqccmGpRMhtw4niDcNx/bMNUhQ/Z8s4t6SxAXZP99VwCyMMtV3hI8L RqAaSO9n9kH4QsVdsuwrP6dV3rIQbRw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210165 On 7/15/26 9:11 AM, Varadarajan Narayanan wrote: > RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND > share the GPIOs. The board has to be reworked to change from EMMC > to NAND variant. Hence add the NAND node but do not enable it. Does that warrant adding a DT for both variants, both inheriting a common .dtsi and making the necessary amends? > Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash Are they controllable? Are they provided by some PMIC? [...] > +&pcie0 { > + pinctrl-0 = <&pcie0_default_state>; > + pinctrl-names = "default"; > + status = "okay"; Please keep a \n before 'status', uniformly, file-wide Also 'pcie0' goes before 'pcie0_foo' Konrad