From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188AbbKXPJH (ORCPT ); Tue, 24 Nov 2015 10:09:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:38344 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753294AbbKXPJF (ORCPT ); Tue, 24 Nov 2015 10:09:05 -0500 Message-ID: <56547D8F.5060701@suse.de> Date: Tue, 24 Nov 2015 16:09:03 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Rasmus Villemoes , Christoph Hellwig , Bart Van Assche , "James E.J. Bottomley" , Julian Calaby CC: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k References: <1448358147-23663-1-git-send-email-linux@rasmusvillemoes.dk> In-Reply-To: <1448358147-23663-1-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/2015 10:42 AM, Rasmus Villemoes wrote: > This reduces the impact of choosing CONFIG_SCSI_CONSTANTS by about 8KB. > > 2dd951ecd511 ("scsi: Conditionally compile in constants.c") updated > the Kconfig help text from 12KB to 75KB. The 12K predated git so was > certainly outdated. But I'm not sure where the 75K comes from; using > size(1) on a defconfig (with/without this config option) vmlinux shows > a difference of about 47K, and 39K after these patches are applied. In > any case, I've left the Kconfig text alone, since I'm not sure I'm > counting the same way the 75K was computed (I'm fairly certain of the > 8K delta, however). > > Tested with a trivial module calling scsi_extd_sense_format with a few > random known codes and comparing the result to the expected value. > > v2: prepend patch to unsplit a few string literals for greppability, > leave the NULL sentinel in the .c file in 2/3 (it's removed in 3/3 > either way). > > Rasmus Villemoes (3): > scsi: make some Additional Sense strings more grep'able > scsi: move Additional Sense Codes to separate file > scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k > > drivers/scsi/constants.c | 859 ++------------------------------------------- > drivers/scsi/sense_codes.h | 826 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 847 insertions(+), 838 deletions(-) > create mode 100644 drivers/scsi/sense_codes.h > For the whole series: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)