From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1309C22A7ED for ; Tue, 29 Apr 2025 21:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745963997; cv=none; b=OdImf9Ezyzf8VbKgi7+P+Ool+R9pYJRzfu7xC7IMnztw7MlijP3wwIzUGmHx9McTE/hbD2VL0zJRPikwNjyhbct7HZZOdPAczHityUnlNE6nbCqWcU6gtFqr0nrtvIOv9p4KRBin5CVgsRC+diy7Pid+8yjXRGKDy8xQWtb9CXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745963997; c=relaxed/simple; bh=N34ZWyGVAGJeTxQZrniCK0fGcuUFW5v2qIPN1hEiIMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ixnS6FteTlBfdCI0AjhVOJtOIqChhqEslfUR6sYjG0C5Dd8HrYQih3qfrNzdiALHCCt1SN/vezYu7GpnnMiiwExKkez60IsyCp1BXIt3MK6g9kon2xfxg5f3pjWJoVX5Mg/xGXu+BvTcHs3ZryIxJpsc9rn/hXGCfhpm0JSAZ3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=cloud.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=R8Xz8tTQ; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="R8Xz8tTQ" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43d2d952eb1so43343085e9.1 for ; Tue, 29 Apr 2025 14:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1745963994; x=1746568794; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6dzUUs9PHGNaWyx7sMbE5O+dXkRC6SHo7Jar916xxOA=; b=R8Xz8tTQlyPCnIrePjwopLGQKbKgkPlcIiPq308q0dHr2CdfxffVk6esFzU4ONOzH9 El2SN2Nvi9w+NyvC3M6wsmflHzkN+AaSmQrWptnnip8/uBy/D8/9PfHGbsCvsnRY3XVp S8FqO09vbsOo2+kjD0dmzIxk7I3UEW5aujDDo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745963994; x=1746568794; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6dzUUs9PHGNaWyx7sMbE5O+dXkRC6SHo7Jar916xxOA=; b=wDzwO8eSTgkVQBtyrl57xlVvU80xiZRG5NOH/D+0lV+c9tokDoO0ICuotdqiS2b7lE o97fRW17LEJtb5yqEvugvZBnZS2LP7zhSEIBHSAb4tbIBRCXq8RBrubx8dRPRw2JKD2Z YKzfKV+Gc4mKa/7EjbXb4yxqKmGcXwUEjjIXqDb7QPS7Pth2461mg39ml2h+2J4b/SWE mOp0jhaIhL1TCN6kNxmtuu9GdHE5v0wU3FsTj0OyONDHbGYqpDkGQ7UJSsG92cjw6fo+ f3yBc3i/ClSZEdjWu37ugkt+4ffJK3+UHkIZt/7IAHe8Fr9wAnZ1NRN5bs29Y0njpbE1 L6aA== X-Forwarded-Encrypted: i=1; AJvYcCUTvkyBwIj1Vgtt61if/p/Vh0RhEnG38cE0LotsLTVzVYO6wIWrGM+hqkO6sb3/f4k4tYkL3hYR9bUBJtE=@vger.kernel.org X-Gm-Message-State: AOJu0YzwOqLTEWMehQ1LCEl+BJQ1RuVJmk17GhoFnvSkWY9pM4svaO8b zQziOyEbcp1sGaWog3lDbClfe4C+kumsJCaBO+kRYeCVy7DNoDkjvFtBNGFBKoQ= X-Gm-Gg: ASbGncvwxgvaHo3asoFbXr+nUqxfP7aHq45H26bDT72SOaCTh0nKW2ah4br//7Wgegh W05LMTn0tLVN+x2VM2lyVYayoX4UWBnrbpADSZIlwZxLJQGBmAXkYJaVfVxkY71jiWxJ41G4Pzj c87FD42SvdNgd4I6lg8PXWZPOhzRYO+kCOMFYfC+8G7ogEHe+dr1Vs5io4P7l9uxZsveiCkqDjJ /WaDUce/fmw3lIId4vDQGxMiC0pylwaKoUg7K959NjyoOaaK+0YeNbfVWV7tLxs67ynKmwQjwmh YZKEZDQUGtRQASZwc3CtuZ0QNkpKqseCQJSZNTo4A1sUekn4IIXoBMS5E/bHLNPM8WmcSD3a5lE MrSU/MVXCs+CwyX9n X-Google-Smtp-Source: AGHT+IHY4cy7uLjQEgNWyNiMXezrWzP1fls3JqJAD5jOL0ln9GwzkgsvNYrkR6Xino4KLtyzyycz0g== X-Received: by 2002:a05:600c:4f8b:b0:43c:e2dd:98ea with SMTP id 5b1f17b1804b1-441b1f5b98emr5409965e9.22.1745963994347; Tue, 29 Apr 2025 14:59:54 -0700 (PDT) Received: from [192.168.1.183] (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8d769sm15337488f8f.12.2025.04.29.14.59.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 14:59:53 -0700 (PDT) Message-ID: <565ac06a-005f-4b77-930e-d63285c025b9@citrix.com> Date: Tue, 29 Apr 2025 22:59:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bitops/32: Convert variable_ffs() and fls() zero-case handling to C To: Linus Torvalds , "H. Peter Anvin" Cc: Ingo Molnar , Arnd Bergmann , Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Juergen Gross , Boris Ostrovsky , Alexander Usyskin , Greg Kroah-Hartman , =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= , Mike Rapoport , Ard Biesheuvel , Peter Zijlstra , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20250425141740.734030-1-arnd@kernel.org> <67be5eee-b67b-409a-8309-829f891b9944@citrix.com> <916BD58C-E6A7-495E-9A60-722E130AC7A7@zytor.com> <956DB0ED-F3DB-456D-8D06-6F40DBDB815A@zytor.com> <06d04c13-76e8-45fb-a563-e365e1f19362@citrix.com> <81ed8b53-1a40-4777-ab87-4f4abe032dbc@citrix.com> <72078B8D-F03E-4783-8AC2-A36464A4B6A1@zytor.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/04/2025 10:53 pm, Linus Torvalds wrote: > I just did > > gcc -m32 -O2 -S -fomit-frame-pointer t.c > > (with, and without that -m32) and looked at the result to see that it > looks sane. No *actual* testing. do_variable_ffs() doesn't quite work. REP BSF is LZCNT, and unconditionally writes it's output operand, and defeats the attempt to preload with -1. Drop the REP prefix, and it should work as intended. ~Andrew