From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: lee.jones@linaro.org, gwendal@chromium.org, bleung@chromium.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
kernel@collabora.com, dtor@chromium.org,
rushikesh.s.kadam@intel.com
Subject: Re: [PATCH v3 2/4] mfd: cros_ec: instantiate properly CrOS ISH MCU device
Date: Mon, 8 Apr 2019 12:39:48 +0200 [thread overview]
Message-ID: <565c3640-97ab-4a8c-e5bd-fb47d3fd3dfb@collabora.com> (raw)
In-Reply-To: <20190408102825.GJ9224@smile.fi.intel.com>
On 8/4/19 12:28, Andy Shevchenko wrote:
> On Mon, Apr 08, 2019 at 11:41:39AM +0200, Enric Balletbo i Serra wrote:
>> From: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
>>
>> Integrated Sensor Hub (ISH) is also a MCU running EC
>> having feature bit EC_FEATURE_ISH. Instantiate it as
>> a special CrOS EC device with device name 'cros_ish'.
>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
>> Changes in v3:
>> - Fix Andy Shevchenko email.
>
The fix was s/andry/andriy/ For some reason I missed an 'i' in your name and the
email obviously bounced for your address.
> I'm not sure what it means.
> I'm using @linux.intel.com for OSS work.
>
Seems that you used andriy.shevchenko@intel.com instead, see:
https://lore.kernel.org/patchwork/patch/1047022/
The part that says:
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
next prev parent reply other threads:[~2019-04-08 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 9:41 [PATCH v3 0/4] mfd: cros_ec: Instantiate CrOS FP, TP and ISH devices Enric Balletbo i Serra
2019-04-08 9:41 ` [PATCH v3 1/4] mfd: cros_ec: Update the EC feature codes Enric Balletbo i Serra
2019-05-08 11:56 ` Lee Jones
2019-04-08 9:41 ` [PATCH v3 2/4] mfd: cros_ec: instantiate properly CrOS ISH MCU device Enric Balletbo i Serra
2019-04-08 10:28 ` Andy Shevchenko
2019-04-08 10:39 ` Enric Balletbo i Serra [this message]
2019-04-08 12:39 ` Andy Shevchenko
2019-04-08 9:41 ` [PATCH v3 3/4] mfd: cros_ec: instantiate properly CrOS FP " Enric Balletbo i Serra
2019-04-08 18:19 ` Benson Leung
2019-04-08 9:41 ` [PATCH v3 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad " Enric Balletbo i Serra
2019-04-08 18:19 ` Benson Leung
2019-05-08 8:14 ` [PATCH v3 0/4] mfd: cros_ec: Instantiate CrOS FP, TP and ISH devices Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565c3640-97ab-4a8c-e5bd-fb47d3fd3dfb@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=dtor@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rushikesh.s.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome