From: Qinyun Tan <qinyuntan@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev, mkoutny@suse.com,
david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
usama.arif@linux.dev, david@fromorbit.com, qi.zheng@linux.dev,
yosry@kernel.org, nphamcs@gmail.com, chengming.zhou@linux.dev,
xlpang@linux.alibaba.com, ryncsn@gmail.com, gourry@gourry.net,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 RESEND 0/5] mm: restore per-memcg reclaim for NONSLAB shrinkers under nokmem
Date: Fri, 20 Nov 2026 15:04:37 +0800 [thread overview]
Message-ID: <565e4075-2788-4310-8309-7739b9ee94ed@linux.alibaba.com> (raw)
In-Reply-To: <20261109215053.85df5685da951ab47ef858f1@linux-foundation.org>
On 11/10/26 1:50 PM, Andrew Morton wrote:
> On Thu, 5 Nov 2026 17:22:28 +0800 Qinyun Tan <qinyuntan@linux.alibaba.com> wrote:
>
>> With cgroup.memory=nokmem, the THP deferred split shrinker and the
>> zswap shrinker are degraded in two ways.
>>
>> First, both shrinkers are missing the SHRINKER_NONSLAB flag, so
>> shrinker_memcg_alloc() demotes them to non-memcg-aware shrinkers:
>> limit-induced reclaim of a cgroup neither splits its partially
>> unmapped THPs nor writes back its zswapped pages. v1 of this series
>> [1] restored the flag to fix that.
>>
>> However, as Sashiko's review of v1 pointed out [2], the flag alone
>> is not enough. __list_lru_init() also collapses every list_lru into
>> per-node lists under nokmem, so even with the flag restored, the
>> objects of all cgroups share one list per node: the per-memcg
>> shrinker bit is only set for whichever memcg happens to repopulate
>> the empty list, so pressure in other cgroups may not even trigger
>> the scan, and when it does, the scan walks everyone's objects.
>
> Thanks. Sashiko still has significant-sounding things to say:
>
> https://sashiko.dev/#/patchset/20261105092233.3558950-1-qinyuntan@linux.alibaba.com
>
> It also says "failed" for reasons I don't understand and it doesn't
> seem to have emailed anyone. Please check it out?
Hi Andrew,
Sorry it's taken me this long to get back to you. I've had a very busy
couple of weeks.
Thanks for pointing me to the report. I looked into the two issues
Sashiko flagged in patch 2/5.
Sashiko pointed out that mem_cgroup_id() identifies the cgroup
directory. We reproduced the ID collision on v4: after disabling and
re-enabling the memory controller on the same cgroup, the old and new
memcgs had the same mem_cgroup_id(). Once the new memcg has its own
LRU list, a lookup for the old memcg can therefore find the new list.
I think memcg->css.id would be a better fit for the list_lru index.
Each per-memcg list belongs to a particular memory CSS, and its ID can
only be reused after the last reference to that CSS is dropped and an
RCU grace period has elapsed. That keeps the indices distinct for as
long as the old CSS can still be accessed.
The second finding is the same race that Shakeel's patch [1] addresses.
It predates this series: a folio can move to the root memcg between
the two lookups in folio_memcg_list_lru_alloc(). Shakeel's patch
rechecks whether allocation is needed after taking the memcg reference.
That also prevents the unnecessary allocation at index 0 that Sashiko
flagged in v4.
Does using the CSS ID for the list_lru index sound reasonable? I'd be
happy to incorporate any suggestions and send a v5.
Best regards,
Qinyun Tan
[1] https://lore.kernel.org/linux-mm/20261112061231.2469026-1-shakeel.butt@linux.dev/
prev parent reply other threads:[~2026-11-20 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 9:22 Qinyun Tan
2026-11-05 9:22 ` [PATCH v4 RESEND 1/5] mm: list_lru: pass the memcg index directly to the walker Qinyun Tan
2026-11-05 9:22 ` [PATCH v4 RESEND 2/5] mm: memcontrol: drop kmemcg_id and use mem_cgroup_id() for list_lru indexing Qinyun Tan
2026-11-05 9:22 ` [PATCH v4 RESEND 3/5] mm: list_lru: keep per-memcg lists with nokmem for NONSLAB-backed lrus Qinyun Tan
2026-11-05 9:22 ` [PATCH v4 RESEND 4/5] mm: thp: restore SHRINKER_NONSLAB on the deferred split shrinker Qinyun Tan
2026-11-05 9:22 ` [PATCH v4 RESEND 5/5] mm: zswap: mark the zswap shrinker SHRINKER_NONSLAB Qinyun Tan
2026-11-10 5:50 ` [PATCH v4 RESEND 0/5] mm: restore per-memcg reclaim for NONSLAB shrinkers under nokmem Andrew Morton
2026-11-20 7:04 ` Qinyun Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565e4075-2788-4310-8309-7739b9ee94ed@linux.alibaba.com \
--to=qinyuntan@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=david@fromorbit.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=ryncsn@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=usama.arif@linux.dev \
--cc=xlpang@linux.alibaba.com \
--cc=yosry@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®