From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nabige Aala <nabige.aala@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Shawn Guo <shengchao.guo@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>,
Mahadevan P <mahadevan.p@oss.qualcomm.com>
Subject: Re: [PATCH v2 02/13] dt-bindings: display: msm: Document the Nord DiplayPort controller
Date: Wed, 21 Oct 2026 13:53:17 +0200 [thread overview]
Message-ID: <565fd4c2-2d5a-4c2a-9ed1-c7bcb17efc9d@kernel.org> (raw)
In-Reply-To: <425ddb41-cfd7-4032-8666-0193ab6b5819@oss.qualcomm.com>
On 21/10/2026 13:16, Nabige Aala wrote:
>
> On 10/13/2026 2:18 PM, Krzysztof Kozlowski wrote:
>> On Tue, Oct 13, 2026 at 09:44:15AM +0200, Krzysztof Kozlowski wrote:
>>> On Mon, Oct 12, 2026 at 07:02:12PM +0530, Nabige Aala wrote:
>>>> From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
>>>>
>>>> Nord uses MDSS 12.1 with two independent DP controller instances,
>>>> each exposing two DP cores at new IO offsets. None of the existing
>>>> compatibles match this layout, so add qcom,nord-dp.
>>>>
>>>> Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
>>>> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
>>> Do I understand correctly:
>>> Device is fully compatible with qcom,sa8775p-dp, but a simple to fix
>>> driver limitation is preventing compatibility?
>>>
>>> If so, let's fix the driver - just add more addresses to the
>>> msm_dp_desc_sa8775p array?
>> Or it does not matter, because top-level MDSS anyway cannot use
>> compatibility?
>
> For MDSS0, the DP register offsets are same to those used on SA8775P.
> However, the MDSS1 DP register offsets differ from SA8775P, and Nord
> also utilizes a different MDSS instance. Because of these differences,
> we introduced a separate compatible string for Nord.
>
> Are you suggesting that Nord should reuse the "msm_dp_desc_sa8775p"?
> This would also pollute the sa8775p's desc table.
What are the differences? Only registers, so no pollution. You just need
them to match IDs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-21 11:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:32 [PATCH v2 00/13] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-10-12 13:32 ` [PATCH v2 01/13] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-10-13 7:37 ` Krzysztof Kozlowski
2026-10-12 13:32 ` [PATCH v2 02/13] dt-bindings: display: msm: Document the Nord DiplayPort controller Nabige Aala
2026-10-13 7:44 ` Krzysztof Kozlowski
2026-10-13 8:48 ` Krzysztof Kozlowski
2026-10-21 11:16 ` Nabige Aala
2026-10-21 11:53 ` Krzysztof Kozlowski [this message]
2026-10-21 12:00 ` Nabige Aala
2026-10-21 12:08 ` Krzysztof Kozlowski
2026-10-12 13:32 ` [PATCH v2 03/13] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-10-13 8:48 ` Krzysztof Kozlowski
2026-10-12 13:32 ` [PATCH v2 04/13] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-10-13 9:28 ` Dmitry Baryshkov
2026-10-12 13:32 ` [PATCH v2 05/13] drm/msm: mdss: Add support for MDSS " Nabige Aala
2026-10-12 13:32 ` [PATCH v2 06/13] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-10-12 14:01 ` Konrad Dybcio
2026-10-13 9:18 ` Dmitry Baryshkov
2026-10-14 9:19 ` Nabige Aala
2026-10-12 13:32 ` [PATCH v2 07/13] phy: qcom: edp: Add Nord-specific register offsets Nabige Aala
2026-10-13 8:43 ` Abel Vesa
2026-10-13 10:19 ` Dmitry Baryshkov
2026-10-21 11:23 ` Nabige Aala
2026-10-12 13:32 ` [PATCH v2 08/13] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-10-13 10:26 ` Dmitry Baryshkov
2026-10-12 13:32 ` [PATCH v2 09/13] phy: qcom: edp: Add Nord voltage-swing and pre-emphasis tables Nabige Aala
2026-10-13 8:44 ` Abel Vesa
2026-10-13 10:27 ` Dmitry Baryshkov
2026-10-12 13:32 ` [PATCH v2 10/13] phy: qcom: edp: Add Nord spread-spectrum clocking configuration callback Nabige Aala
2026-10-13 8:47 ` Abel Vesa
2026-10-13 10:28 ` Dmitry Baryshkov
2026-10-12 13:32 ` [PATCH v2 11/13] phy: qcom: edp: Add Nord PLL " Nabige Aala
2026-10-12 13:32 ` [PATCH v2 12/13] phy: qcom: edp: Add Nord PHY configuration data tables Nabige Aala
2026-10-13 10:33 ` Dmitry Baryshkov
2026-10-12 13:32 ` [PATCH v2 13/13] phy: qcom: edp: Add Nord phy_cfg, ops and OF compatible Nabige Aala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565fd4c2-2d5a-4c2a-9ed1-c7bcb17efc9d@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mahadevan.p@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_khsieh@quicinc.com \
--cc=ritesh.kumar@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®