From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759737AbbLCLI6 (ORCPT ); Thu, 3 Dec 2015 06:08:58 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38662 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759832AbbLCLH0 (ORCPT ); Thu, 3 Dec 2015 06:07:26 -0500 Subject: Re: linux-next: build failure after merge of the block tree To: Christoph Hellwig References: <20151202161936.22b23668cf9dea9872b5079b@kernel.org> <20151202164527.GA31048@lst.de> <565F5D96.5050902@kernel.dk> <565FFFA5.6000003@bjorling.me> <20151203090638.GA14329@lst.de> <566010EE.6050806@bjorling.me> <20151203095726.GA15428@lst.de> <566014BF.3080702@bjorling.me> <20151203102132.GA15905@lst.de> Cc: Jens Axboe , Mark Brown , Keith Busch , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Organization: Paletta Message-ID: <5660226B.5070800@bjorling.me> Date: Thu, 3 Dec 2015 12:07:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151203102132.GA15905@lst.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2015 11:21 AM, Christoph Hellwig wrote: > On Thu, Dec 03, 2015 at 11:09:03AM +0100, Matias Bjørling wrote: >> Similar to this? > > For the interface yes. Now just get rid of using nvme_ns entirely - > seems like you just want ns_id and lba_shift, and those should fit > well into nvm_dev I think. > What is the reason to keep the nvme_ns internally to the nvme core? We can definitely move ->nsid and the lba_shift into nvm_dev. Only thing I have is that it moves a small part of nvme logic into the lightnvm core.