From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbLCS2z (ORCPT ); Thu, 3 Dec 2015 13:28:55 -0500 Received: from lists.s-osg.org ([54.187.51.154]:56853 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267AbbLCS2x (ORCPT ); Thu, 3 Dec 2015 13:28:53 -0500 Subject: Re: [PATCH 0/2] ARM: dts: Use MMC pwrseq instead regulators for IGEP WiFi init To: Tony Lindgren References: <1449165729-993-1-git-send-email-javier@osg.samsung.com> <20151203181624.GW23396@atomide.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Enric Balletbo i Serra Message-ID: <566089E1.7050805@osg.samsung.com> Date: Thu, 3 Dec 2015 15:28:49 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151203181624.GW23396@atomide.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tony, On 12/03/2015 03:16 PM, Tony Lindgren wrote: > * Javier Martinez Canillas [151203 10:03]: >> Hello, >> >> This series converts the IGEPv2 (IGEP0020) and IGEP COM Module (IGEP0030) >> Device Tree to use the MMC power sequence provider to initialize the SDIO >> WiFi chip instead of using fake fixed regulators to just toggle the Reset >> and Power pins in the chip. >> >> The patches were tested on an DM3730 IGEPv2 board but the IGEP COM Module >> is the same with regard to the SDIO WiFi so it should be safe to land too. >> >> The IGEPv2 Rev.F and the IGEP COM Module Rev.G DTS were not converted due >> using a different WiFi chip (wlcore instead of libertas) than the one in >> the board I've access to test so I preferred to leave those untouched. > > Do you have some solution for the start-up latency issue? > No, I don't and that's one of the reasons why I didn't want to touch the DTS that have the wlcore chip. The omap3-igep0020-rev-f.dts and omap3-igep0030-rev-g.dts don't have a startup-delay-us property in the regulator for the WLAN_EN pin as is the case for the IGEPv5 DTS but I don't know if those DTS are just wrong. The DTS for the igep0020 and igep0030 that have the libertas chip, did have a startup-delay-us for the WIFI_PDN but using the GPIOs for RESET_N_W and WIFI_PDN in the mmc-pwrseq-simple reset-gpios is enough to make the SDIO chip reset, be enumerated and WiFi to work correctly so I don't know if that is really needed or is just a bad description in the DTS. Since is working for the boards with the libertas chip, I preferred to remove the DTS hack but left the boards with wlcore chip since you said the startup-delay-us is needed there (but probably we should add to the regulators in the boards that don't have it then). > Regards, > > Tony > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America