mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Shah, Yash (Y.)" <yshah1@visteon.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Babu, Viswanathan (V.)" <vbabu3@visteon.com>
Subject: Re: [PATCH] Staging: cdrom: fix space required after that ','
Date: Fri, 4 Dec 2015 09:43:40 -0700	[thread overview]
Message-ID: <5661C2BC.9030007@kernel.dk> (raw)
In-Reply-To: <20151204092130.GA6979@ubuntu>

On 12/04/2015 02:21 AM, Shah, Yash (Y.) wrote:
> From: Yash Shah<yshah1@visteon.com>
 >
> -#define copy_key(dest,src)	memcpy((dest), (src), sizeof(dvd_key))
> -#define copy_chal(dest,src)	memcpy((dest), (src), sizeof(dvd_challenge))
> +#define copy_key(dest, src)	memcpy((dest), (src), sizeof(dvd_key))
> +#define copy_chal(dest, :src)	memcpy((dest), (src), sizeof(dvd_challenge))

Sending patches that you haven't even compiled:

https://www.youtube.com/watch?v=y94KynIg-g8

-- 
Jens Axboe


      parent reply	other threads:[~2015-12-04 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  9:21 Shah, Yash (Y.)
2015-12-04  9:33 ` kbuild test robot
2015-12-04 10:37 ` Geyslan G. Bem
2015-12-04 10:49   ` Shah, Yash (Y.)
2015-12-04 16:49     ` Jens Axboe
2015-12-04 16:43 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5661C2BC.9030007@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vbabu3@visteon.com \
    --cc=yshah1@visteon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®