mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Robert Kmiec <robert.r.kmiec@gmail.com>,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	denis.ciocca@st.com, linus.walleij@linaro.org,
	giuseppe.barba@st.com, alban.bedel@avionic-design.de,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: st_accel_core: Remove unneeded define
Date: Sat, 5 Dec 2015 17:29:08 +0000	[thread overview]
Message-ID: <56631EE4.7080002@kernel.org> (raw)
In-Reply-To: <1449186888-22070-1-git-send-email-robert.r.kmiec@gmail.com>

On 03/12/15 23:54, Robert Kmiec wrote:
> Definition of ST_SENSORS_WAI_ADDRESS was introduced within a very
> first commit of this driver, but it was never used.
> This address is already defined as ST_SENSORS_DEFAULT_WAI_ADDRESS
> in include/linux/iio/common/st_sensors.h
> 
> To avoid duplication of the same constant in two different places
> called almost exactly the same, the one which was never used
> should be removed.
> 
> Signed-off-by: Robert Kmiec <robert.r.kmiec@gmail.com>
Fair enough.

Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/common/st_sensors/st_sensors_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index 25258e2..8447c31 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -18,9 +18,6 @@
>  #include <asm/unaligned.h>
>  #include <linux/iio/common/st_sensors.h>
>  
> -
> -#define ST_SENSORS_WAI_ADDRESS		0x0f
> -
>  static inline u32 st_sensors_get_unaligned_le24(const u8 *p)
>  {
>  	return (s32)((p[0] | p[1] << 8 | p[2] << 16) << 8) >> 8;
> 


      reply	other threads:[~2015-12-05 17:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 23:54 Robert Kmiec
2015-12-05 17:29 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56631EE4.7080002@kernel.org \
    --to=jic23@kernel.org \
    --cc=alban.bedel@avionic-design.de \
    --cc=denis.ciocca@st.com \
    --cc=giuseppe.barba@st.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robert.r.kmiec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome