From: Jens Axboe <axboe@kernel.dk>
To: NeilBrown <neilb@suse.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Two fixes for loop devices
Date: Sun, 18 Jun 2017 09:06:49 -0600 [thread overview]
Message-ID: <56640935-e897-1586-5493-1cf1ffc98ba9@kernel.dk> (raw)
In-Reply-To: <87bmpl6hkq.fsf@notabene.neil.brown.name>
On 06/17/2017 10:33 PM, NeilBrown wrote:
> On Fri, Jun 16 2017, Jens Axboe wrote:
>
>> On 06/15/2017 11:02 PM, NeilBrown wrote:
>>> Hi Jens,
>>> one of these is a resend of a patch I sent a while back.
>>> The other is new - loop closes files differently from close()
>>> and in a way that can confuse NFS.
>>
>> Are you wanting to get these into 4.12, or defer to 4.13?
>
> I'm happy either way. I just want them to land eventually, so I can
> tick them off my list.
>
> The conversation with Al might result in a different fix for the
> flip_close() problem, but I think that it is still more correct to call
> filp_close(), because what loop is doing is a lot like closing a file
> that it has been writing to.
I'll toss 2/2 in for now for 4.13, please resend the other once the issues
have been ironed out.
--
Jens Axboe
prev parent reply other threads:[~2017-06-18 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 5:02 NeilBrown
2017-06-16 5:02 ` [PATCH 1/2] loop: use filp_close() rather than fput() NeilBrown
2017-06-16 7:37 ` Christoph Hellwig
2017-06-17 0:01 ` Al Viro
2017-06-18 4:30 ` NeilBrown
2017-06-16 5:02 ` [PATCH 2/2] loop: Add PF_LESS_THROTTLE to block/loop device thread NeilBrown
2017-06-16 7:36 ` Christoph Hellwig
2017-06-16 14:29 ` [PATCH 0/2] Two fixes for loop devices Jens Axboe
2017-06-18 4:33 ` NeilBrown
2017-06-18 15:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56640935-e897-1586-5493-1cf1ffc98ba9@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome