From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932495AbbLHC4w (ORCPT ); Mon, 7 Dec 2015 21:56:52 -0500 Received: from darkcity.gna.ch ([195.226.6.51]:47946 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755267AbbLHC4v (ORCPT ); Mon, 7 Dec 2015 21:56:51 -0500 Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. To: Eric Anholt , Emil Velikov References: <1449002158-19156-1-git-send-email-eric@anholt.net> <1449002158-19156-3-git-send-email-eric@anholt.net> <87bna1d9js.fsf@eliezer.anholt.net> Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel From: =?UTF-8?Q?Michel_D=c3=a4nzer?= X-Enigmail-Draft-Status: N1110 Message-ID: <566646EB.3050406@daenzer.net> Date: Tue, 8 Dec 2015 11:56:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0 MIME-Version: 1.0 In-Reply-To: <87bna1d9js.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.12.2015 10:16, Eric Anholt wrote: > Emil Velikov writes: > >> Hi Eric, >> >> A couple of suggestions/requests on the UAPI header side >> >> On 1 December 2015 at 20:35, Eric Anholt wrote: >> >>> --- /dev/null >>> +++ b/include/uapi/drm/vc4_drm.h >> >>> +#include >>> + >> Can we make this a "drm.h" ? > > Nope. > > include/uapi/drm/vc4_drm.h:27:17: fatal error: drm.h: No such file or directory What happened to include/uapi/drm/drm.h in that tree? > and none of the drivers do, either. daenzer@kaveri|11:55:31> grep '#include "drm.h"' include/uapi/drm/* include/uapi/drm/amdgpu_drm.h:#include "drm.h" include/uapi/drm/radeon_drm.h:#include "drm.h" Patches to convert the rest are pending. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer