Re: [PATCH v8 3/6] mm/page_alloc: add support for initializing pageblock as isolated.

[Zi Yan <ziy@nvidia.com>]

On 2 Jun 2025, at 19:52, Zi Yan wrote:

> MIGRATE_ISOLATE is a standalone bit, so a pageblock cannot be initialized
> to just MIGRATE_ISOLATE. Add init_pageblock_migratetype() to enable
> initialize a pageblock with a migratetype and isolated.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> Acked-by: David Hildenbrand <david@redhat.com>
> ---
>  include/linux/memory_hotplug.h |  3 ++-
>  include/linux/page-isolation.h |  3 +++
>  mm/hugetlb.c                   |  4 ++--
>  mm/internal.h                  |  3 ++-
>  mm/memory_hotplug.c            | 12 ++++++++----
>  mm/memremap.c                  |  2 +-
>  mm/mm_init.c                   | 24 +++++++++++++++---------
>  mm/page_alloc.c                | 24 ++++++++++++++++++++++++
>  8 files changed, 57 insertions(+), 18 deletions(-)



From 0e48cfc8fc9e10c1d2fe9bc080af737b4f852347 Mon Sep 17 00:00:00 2001
From: Zi Yan <ziy@nvidia.com>
Date: Mon, 2 Jun 2025 21:51:25 -0400
Subject: [PATCH] fixup: make init_pageblock_migratetype() set right
 migratetype.

when page_group_by_mobility_disabled is 1.

Signed-off-by: Zi Yan <ziy@nvidia.com>
---
 mm/page_alloc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0867e2b2e187..ff098523a501 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -552,12 +552,14 @@ void __meminit init_pageblock_migratetype(struct page *page,
 					  enum migratetype migratetype,
 					  bool isolate)
 {
-	unsigned long flags = migratetype;
+	unsigned long flags;

 	if (unlikely(page_group_by_mobility_disabled &&
 		     migratetype < MIGRATE_PCPTYPES))
 		migratetype = MIGRATE_UNMOVABLE;

+	flags = migratetype;
+
 #ifdef CONFIG_MEMORY_ISOLATION
 	if (migratetype == MIGRATE_ISOLATE) {
 		VM_WARN_ONCE(
-- 
2.47.2




Best Regards,
Yan, Zi