From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbbLKEAp (ORCPT ); Thu, 10 Dec 2015 23:00:45 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:18314 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbbLKEAn (ORCPT ); Thu, 10 Dec 2015 23:00:43 -0500 X-AuditID: cbfec7f5-f79b16d000005389-51-566a4a68c39d Subject: Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties To: Viresh Kumar , Javier Martinez Canillas References: <1449766729-435-1-git-send-email-b.zolnierkie@samsung.com> <1449766729-435-4-git-send-email-b.zolnierkie@samsung.com> <20151211031646.GL3612@ubuntu> <566A4231.9050608@osg.samsung.com> <20151211033253.GN3612@ubuntu> Cc: Bartlomiej Zolnierkiewicz , Thomas Abraham , Sylwester Nawrocki , Mike Turquette , Kukjin Kim , Kukjin Kim , Ben Gamari , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Doug Anderson , Andreas Faerber From: Krzysztof Kozlowski Message-id: <566A4A60.8060402@samsung.com> Date: Fri, 11 Dec 2015 13:00:32 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <20151211033253.GN3612@ubuntu> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Ra0hTYRzGeXcuO44GJ9N8UTBYF2rlvEYv0mUgwUEI7GaXD9qcJzdzujaV rA8tJC+DzZV+0Jm5Qs2WJdvEWzZoppEaJuUsS0VNtDZR0Jmgac4V+e15nv/vgT88FObfgwdT 8sxsVpUpyRCQPLx37a0zTBafnhixeodA+VY1spQ3EshYPYKjocVpAr2ve02i9QkXgdyzDRzk molEOtMgiUomXRjydNYD5B63AWSddBLoY/sDEi3o3gBU3m/noBeWYS4a6DmJOt2FBCqqA6jg 2TyBzO2rAFk8jDiImft8l8tUagZwps04wmWs5mKS+ebsIBlbzW1mrZvLNJVsxPomM2D6VuKY FudDjLH13mIWrKEJ/Mu8o6lshjyXVYUfv8KT2b/YuUoz74auaoXUgFWuFvhRkI6Bn/oe4T69 E34YbSS1gEf507UAjnWsEj4zBWD1qxnMS+2gT8GiNv1mO4BOhh1P+/82ZgCcXxrieg1G60lY 6m4jvBRJR0PbkxrSq/m0EC7rmjlejdN7oaGwFWgBRQXSF+HjVrkP2Q6XS0c3X/KjD8KuXxWY F8FoERwbEHpjjN4FbQ2zmAHQxi0N43/KuIUyAcwMAtkcqVKdkqaIEqklCnVOZppImqWwAt/C nlZQ2x3rADQFBNv4Jio90Z+Q5KrzFA4AKUwQwP8h3oj4qZK8m6wqK1mVk8GqHSCEwgVB/Ir2 uXP+dJokm73GskpW9e/KofyCNcBui+FXukQTlGakRGq6F1Xm6uEbpEmnLUbP0glHSEHt17Lv +0qFZx81GeTWOIJXVuiYcILY/KTFGmVeATF4rBi/Tkyj6PIzz5NTDozv7pd0hV3aHx9xhD1c l1Af0yxuEVZRcVdHwrkm7e/7oRcaxNjLQ2vrw4P6qT3vfsrOC3C1TBIpxFRqyR+PLtEv3QIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.12.2015 12:32, Viresh Kumar wrote: > On 11-12-15, 00:25, Javier Martinez Canillas wrote: >> The problem is that the big and LITTLE cores have different ordering per SoCs: >> >> - Exynos5420 and Exynos5800: cpu0-3 (Cortex-A15) and cpu4-7 (Coretx-A7) >> - Exynos5422: cpu0-3 (Cortex-A7) and cpu4-7 (Cortex-A15) >> >> So the OPP tables are set in this DTSI file, to prevent the OPP tables >> in the Exynos5422 to be inverted for the cluster 0 and 1. > > Oh dude, that's really *ugly*. :) > > Reusing files/definitions is fine to the point where things are > readable. But you have screwed it up so very badly. > > Over that, why can't you keep cpu0-3 as A7 and 4-7 as a15 for all the > cases? The only worrying thing for you should be that CPU0 within the > kenrel should be controllable, right? i.e. you want a A15 to boot 5800 > and A7 to boot 5422. > > If yes, than you could have kept the CPUs in 5422 as: > 0-3: A7 > 4-7: A15 > > and in 5420 as: > 4-7: A15 > 0-3: A7 > > Wouldnt' that work ? It wasn't working like this. The cpu0 got the index from booting cpu, so on 5420 cpu0 was A15 and on 5422 it was A7. Maybe I am not aware of some changes recently in the kernel but how do you want to assign the booting CPU proper number (not CPU0)? Best regards, Krzysztof