From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbbLKESY (ORCPT ); Thu, 10 Dec 2015 23:18:24 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:18637 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbbLKESW (ORCPT ); Thu, 10 Dec 2015 23:18:22 -0500 X-AuditID: cbfec7f5-f79b16d000005389-cc-566a4e8b7782 Subject: Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties To: Viresh Kumar References: <1449766729-435-1-git-send-email-b.zolnierkie@samsung.com> <1449766729-435-4-git-send-email-b.zolnierkie@samsung.com> <20151211031646.GL3612@ubuntu> <566A4231.9050608@osg.samsung.com> <20151211033253.GN3612@ubuntu> <566A4A60.8060402@samsung.com> <20151211041349.GO3612@ubuntu> Cc: Javier Martinez Canillas , Bartlomiej Zolnierkiewicz , Thomas Abraham , Sylwester Nawrocki , Mike Turquette , Kukjin Kim , Kukjin Kim , Ben Gamari , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Doug Anderson , Andreas Faerber From: Krzysztof Kozlowski Message-id: <566A4E82.3040203@samsung.com> Date: Fri, 11 Dec 2015 13:18:10 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <20151211041349.GO3612@ubuntu> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t/xK7rdfllhBl9fa1o0byq22DhjPavF rPl3WSyuf3nOanF22UE2i/+PXrNavHm7hsni9QtDi94FV9ks+h+/Zrb4engFo8Wbh5sZLTY9 vsZqcXnXHDaLz71HGC1mnN/HZLFu4y12i4unXC0Ov2lntehYxmjRtvoDq8WqXX8YLTZ+9XAQ 93h/o5XdY3bDRRaPnbPusntsWtXJ5nHn2h42j81L6j3+HWP32NIPFO7bsorR48xvZ4/t1+Yx e2w+Xe3xeZNcAG8Ul01Kak5mWWqRvl0CV0bnivmsBc/4K+avvsjSwNjI1cXIySEhYCJxYct3 RghbTOLCvfVsXYxcHEICSxklTm6aywThPGWUeH7tCjNIlbCAr0THzj72LkYODhEBLYmXN1NB wkICK5gkdn7VAqlnFjjMJrFk10MWkASbgLHE5uVL2EBsXqD6uw+awGwWAVWJ9inTweaICkRI LNqRCVEiKPFj8j2wVk4BbYlzsxaDlTAL6Encv6gFEmYWkJfYvOYt8wRGgVlIOmYhVM1CUrWA kXkVo2hqaXJBcVJ6rpFecWJucWleul5yfu4mRkj8ft3BuPSY1SFGAQ5GJR7eBRxZYUKsiWXF lbmHGCU4mJVEeF86AIV4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgm y8TBKdXAuKM8Z+HraRmr1qrvWrjrpuXTqzHhVSt3cSkk2R85ZdPIcIAv0EN12TmHRHY7Sy77 1nCehebbppr+cNjzcP9ueYnaPcZNzOJ7j2yynn9L+PyvbzwfT/eKhyeL2dzYoBpzOuIzZ0v/ yhAex9tZd/o5T7pYHzXrnPfQhW91SZfwtaWp8eKa/rNXKbEUZyQaajEXFScCAPDWSm3bAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.12.2015 13:13, Viresh Kumar wrote: > On 11-12-15, 13:00, Krzysztof Kozlowski wrote: >> It wasn't working like this. The cpu0 got the index from booting cpu, so >> on 5420 cpu0 was A15 and on 5422 it was A7. >> >> Maybe I am not aware of some changes recently in the kernel but how do >> you want to assign the booting CPU proper number (not CPU0)? > > Okay, this is how it works and I don't think you need to change the > order of CPUs based on machines. > > The boot CPU isn't controlled by the DT file but your bootloader, so > it will be A15 on 5420 and A7 on 5422. > > Now if you keep the order in DT as: 0-3 A7 and 4-7 A15 irrespective of > the SoCs, then this is how they will be assigned. > > Linux CPU numbers Actual CPU assigned to them > 5420 5422 > > CPU0 A15-0 (boot) A7-0 (boot) > CPU1 A7-0 A7-1 > CPU2 A7-1 A7-2 > CPU3 A7-2 A7-3 > CPU4 A7-3 A15-0 > CPU5 A15-1 A15-1 > CPU6 A15-2 A15-2 > CPU7 A15-3 A15-3 > > This happens because all non-boot CPUs will be added in the order they > are present in DT. > > Now, there should be no *real* reason for you to want your CPUs to be > always contiguous, isn't it? > > In the case of 5420, cpufreq will show related CPUs as: > Policy0: CPU0,5-7, Policy1: CPU1-4 > > and in the case of 5422, cpufreq will show related CPUs as: > Policy0: CPU0-3, Policy1: CPU4-7 > > And I think you should really fix this now.. We had such configuration before (before df09df6f9ac3). I don't see any benefit in what you described. Where is the "thing" to be fixed? It is mixed up. The contiguous ordering is easier to read and more natural. Best regards, Krzysztof