From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbbLKIhc (ORCPT ); Fri, 11 Dec 2015 03:37:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:52879 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbbLKIha (ORCPT ); Fri, 11 Dec 2015 03:37:30 -0500 Subject: Re: [PATCH] scsi_dh_alua: fix build warning To: Sudip Mukherjee , "James E.J. Bottomley" , "Martin K. Petersen" References: <1449822963-9054-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org From: Hannes Reinecke Message-ID: <566A8B47.8090805@suse.de> Date: Fri, 11 Dec 2015 09:37:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449822963-9054-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2015 09:36 AM, Sudip Mukherjee wrote: > We were getting build warning about unused variables "vpd_pg83" and "d" > > Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()") > Cc: Hannes Reinecke > Signed-off-by: Sudip Mukherjee > --- > build warning with next-20151211 and build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206 > --- > > drivers/scsi/device_handler/scsi_dh_alua.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c > index f100cbb..5a328bf 100644 > --- a/drivers/scsi/device_handler/scsi_dh_alua.c > +++ b/drivers/scsi/device_handler/scsi_dh_alua.c > @@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev) > */ > static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h) > { > - unsigned char *d; > - unsigned char __rcu *vpd_pg83; > int rel_port = -1, group_id; > > group_id = scsi_vpd_tpg_id(sdev, &rel_port); > A fix for this is already queued in Martin Petersens tree. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)