mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: myungjoo.ham@samsung.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, robh@kernel.org
Subject: Re: [PATCH 3/3] extcon: arizona: Add DT binding examples
Date: Tue, 15 Dec 2015 10:00:26 +0900	[thread overview]
Message-ID: <566F662A.8080601@samsung.com> (raw)
In-Reply-To: <1450089433-11398-3-git-send-email-ckeepax@opensource.wolfsonmicro.com>

On 2015년 12월 14일 19:37, Charles Keepax wrote:
> Add an example for all elements of the Arizona extcon device tree
> binding.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  .../devicetree/bindings/extcon/extcon-arizona.txt  | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> index fd9b898..e27341f 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> @@ -47,3 +47,29 @@ Optional properties:
>      The third cell represents the value of the micd-pol-gpio pin.
>  
>    - wlf,gpsw : Settings for the general purpose switch
> +
> +Example:
> +
> +codec: wm8280@0 {
> +	compatible = "wlf,wm8280";
> +	reg = <0>;
> +	...
> +
> +	wlf,use-jd2;
> +	wlf,use-jd2-nopull;
> +	wlf,jd-invert;
> +
> +	wlf,micd-software-compare;
> +	wlf,micd-detect-debounce = <0>;
> +	wlf,micd-pol-gpio = <&codec 2 0>;
> +	wlf,micd-rate = <ARIZONA_MICD_TIME_8MS>;
> +	wlf,micd-dbtime = <4>;
> +	wlf,micd-timeout-ms = <100>;
> +	wlf,micd-force-micbias;
> +	wlf,micd-configs = <
> +		0 1 0 /* MICDET1 MICBIAS1 GPIO=low */
> +		1 2 1 /* MICDET2 MICBIAS2 GPIO=high */
> +	>;
> +
> +	wlf,gpsw = <0>;
> +};
> 

Looks good to me. Applied it.

Thanks,
Chanwoo Choi

  reply	other threads:[~2015-12-15  1:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 10:37 [PATCH v2 1/3] extcon: arizona: Add device bindings for the micd configurations Charles Keepax
2015-12-14 10:37 ` [PATCH v2 2/3] extcon: arizona: Update device tree binding for mic detect configurations Charles Keepax
2015-12-15  1:00   ` Chanwoo Choi
2015-12-14 10:37 ` [PATCH 3/3] extcon: arizona: Add DT binding examples Charles Keepax
2015-12-15  1:00   ` Chanwoo Choi [this message]
2015-12-15  1:00 ` [PATCH v2 1/3] extcon: arizona: Add device bindings for the micd configurations Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566F662A.8080601@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome