From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbbLOEle (ORCPT ); Mon, 14 Dec 2015 23:41:34 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:53514 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbbLOEld (ORCPT ); Mon, 14 Dec 2015 23:41:33 -0500 Subject: Re: [PATCH 1/2] cris: debugport: Fix section mismatches To: Mikael Starvik References: <1447193076-16755-1-git-send-email-linux@roeck-us.net> Cc: Jesper Nilsson , linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <566F99FA.5090007@roeck-us.net> Date: Mon, 14 Dec 2015 20:41:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1447193076-16755-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2015 02:04 PM, Guenter Roeck wrote: > Section mismatches can now cause build failures, such as for > cris:allnoconfig. Rename affected variables to end with _console > to make section mismatch checks happy. > > Signed-off-by: Guenter Roeck ping ... cris:allnoconfig still fails to build in mainline. Should I drop the build from my tests ? Thanks, Guenter > --- > arch/cris/arch-v10/kernel/debugport.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/cris/arch-v10/kernel/debugport.c b/arch/cris/arch-v10/kernel/debugport.c > index 7d307cce8bd8..b6549e54be29 100644 > --- a/arch/cris/arch-v10/kernel/debugport.c > +++ b/arch/cris/arch-v10/kernel/debugport.c > @@ -468,7 +468,7 @@ etrax_console_device(struct console* co, int *index) > #endif > } > > -static struct console sercons = { > +static struct console ser_console = { > name : "ttyS", > write: console_write, > read : NULL, > @@ -480,7 +480,7 @@ static struct console sercons = { > cflag : 0, > next : NULL > }; > -static struct console sercons0 = { > +static struct console ser0_console = { > name : "ttyS", > write: console_write, > read : NULL, > @@ -493,7 +493,7 @@ static struct console sercons0 = { > next : NULL > }; > > -static struct console sercons1 = { > +static struct console ser1_console = { > name : "ttyS", > write: console_write, > read : NULL, > @@ -505,7 +505,7 @@ static struct console sercons1 = { > cflag : 0, > next : NULL > }; > -static struct console sercons2 = { > +static struct console ser2_console = { > name : "ttyS", > write: console_write, > read : NULL, > @@ -517,7 +517,7 @@ static struct console sercons2 = { > cflag : 0, > next : NULL > }; > -static struct console sercons3 = { > +static struct console ser3_console = { > name : "ttyS", > write: console_write, > read : NULL, > @@ -539,17 +539,17 @@ init_etrax_debug(void) > static int first = 1; > > if (!first) { > - unregister_console(&sercons); > - register_console(&sercons0); > - register_console(&sercons1); > - register_console(&sercons2); > - register_console(&sercons3); > + unregister_console(&ser_console); > + register_console(&ser0_console); > + register_console(&ser1_console); > + register_console(&ser2_console); > + register_console(&ser3_console); > init_dummy_console(); > return 0; > } > > first = 0; > - register_console(&sercons); > + register_console(&ser_console); > start_port(port); > #ifdef CONFIG_ETRAX_KGDB > start_port(kgdb_port); >