From: maowenan <maowenan@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <gregkh@linuxfoundation.org>, <jslaby@suse.com>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <vz@mleia.com>
Subject: Re: [PATCH serial v3] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()
Date: Fri, 15 Mar 2019 21:56:07 +0800 [thread overview]
Message-ID: <566a03ba-aae9-3169-5db3-3417d5eb60f9@huawei.com> (raw)
In-Reply-To: <20190311121918.GD2412@kadam>
ping...
On 2019/3/11 20:19, Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 05:39:59PM +0800, Mao Wenan wrote:
>> Add the missing uart_unregister_driver() and i2c_del_driver() before
>> return from sc16is7xx_init() in the error handling case.
>>
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
>
> This looks nice. Thanks!
>
> Reviewed-by: Dan Carpeter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
>
>
next prev parent reply other threads:[~2019-03-15 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 9:39 Mao Wenan
2019-03-11 12:19 ` Dan Carpenter
2019-03-15 13:56 ` maowenan [this message]
2019-03-15 14:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566a03ba-aae9-3169-5db3-3417d5eb60f9@huawei.com \
--to=maowenan@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®