From: "Arnd Bergmann" <arnd@arndb.de>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Wei Fang" <wei.fang@nxp.com>, "Jakub Kicinski" <kuba@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>
Cc: "Shenwei Wang" <shenwei.wang@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional
Date: Thu, 02 Feb 2023 10:47:58 +0100 [thread overview]
Message-ID: <566b855b-dbdd-4c10-aac2-262b64343ae6@app.fastmail.com> (raw)
In-Reply-To: <20230201215320.528319-1-dmitry.torokhov@gmail.com>
On Wed, Feb 1, 2023, at 22:53, Dmitry Torokhov wrote:
> Conversion of the driver to gpiod API done in 468ba54bd616 ("fec:
> convert to gpio descriptor") incorrectly made reset line mandatory and
> resulted in aborting driver probe in cases where reset line was not
> specified (note: this way of specifying PHY reset line is actually
> deprecated).
>
> Switch to using devm_gpiod_get_optional() and skip manipulating reset
> line if it can not be located.
>
> Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> v3: removed handling of 'phy-reset-active-high', it was moved to patch #2
> v2: dropped conversion to generic device properties from the patch
Thanks for fixing it,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-02-02 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 21:53 Dmitry Torokhov
2023-02-01 21:53 ` [PATCH v3 2/2] net: fec: do not double-parse 'phy-reset-active-high' property Dmitry Torokhov
2023-02-01 22:54 ` Andrew Lunn
2023-02-01 23:21 ` Dmitry Torokhov
2023-02-02 1:08 ` Dmitry Torokhov
2023-02-02 13:21 ` Andrew Lunn
2023-02-01 21:58 ` [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional Andrew Lunn
2023-02-02 9:45 ` Marc Kleine-Budde
2023-02-02 9:47 ` Arnd Bergmann [this message]
2023-02-03 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566b855b-dbdd-4c10-aac2-262b64343ae6@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®