mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Rob Herring <robh@kernel.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] libperf mmap: Arm64: fix transposed reads of counters 12 and 13
Date: Thu, 19 Nov 2026 10:42:00 +0000	[thread overview]
Message-ID: <56700f45-9cd1-4375-947a-d59f9aeead0d@linaro.org> (raw)
In-Reply-To: <20261118200057.2134362-1-irogers@google.com>



On 18/11/2026 20:00, Ian Rogers wrote:
> Reported in Sashiko bug linux-3291a858-209c-483a-b4dc-eeb57abdaee6,
> the 2 counter read functions for counters 12 and 13 are transposed.
> 
> Fixes: 407eb43ae87c ("libperf: Add arm64 support to perf_mmap__read_self()")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>   tools/lib/perf/mmap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/perf/mmap.c b/tools/lib/perf/mmap.c
> index ab3adf1d8baf..92acb0e911f7 100644
> --- a/tools/lib/perf/mmap.c
> +++ b/tools/lib/perf/mmap.c
> @@ -376,8 +376,8 @@ static u64 read_perf_counter(unsigned int counter)
>   		read_pmevcntr_9,
>   		read_pmevcntr_10,
>   		read_pmevcntr_11,
> -		read_pmevcntr_13,
>   		read_pmevcntr_12,
> +		read_pmevcntr_13,
>   		read_pmevcntr_14,
>   		read_pmevcntr_15,
>   		read_pmevcntr_16,

Reviewed-by: James Clark <james.clark@linaro.org>

Interesting mistake. Doesn't seem to have been copied from any of the 
other enumerations of PMEVCNTR either.


      reply	other threads:[~2026-11-19 10:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 20:00 Ian Rogers
2026-11-19 10:42 ` James Clark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56700f45-9cd1-4375-947a-d59f9aeead0d@linaro.org \
    --to=james.clark@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®