From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222AbbLOTLz (ORCPT ); Tue, 15 Dec 2015 14:11:55 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36387 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbbLOTLv (ORCPT ); Tue, 15 Dec 2015 14:11:51 -0500 Subject: Re: [PATCH v2] extcon: add Maxim MAX3355 driver To: Chanwoo Choi , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <5045536.UEVncNCOZE@wasted.cogentembedded.com> <566F6AEC.1030903@samsung.com> Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <567065F3.6010009@cogentembedded.com> Date: Tue, 15 Dec 2015 22:11:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <566F6AEC.1030903@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2015 04:20 AM, Chanwoo Choi wrote: >> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > ^^ ^^ >> enable a system with an integrated USB OTG dual-role transceiver to function >> as an USB OTG dual-role device. In addition to sensing/controlling Vbus, > ^^ ^^ ^^ ^^ >> the chip also passes thru the ID signal from the USB OTG connector. > ^^ >> On some Renesas boards, this signal is just fed into the SoC thru a GPIO > ^^ ^^ >> pin -- there's no real OTG controller, only host and gadget USB controllers > ^^ ^^ >> sharing the same USB bus; however, we'd like to allow host or gadget drivers > ^^ >> to be loaded depending on the cable type, hence the need for the MAX3355 > ^^ >> extcon driver. The Vbus status signals are also wired to GPIOs (however, we >> aren't currently interested in them), the OFFVBUS# signal is controlled by > ^^ ^^ >> the host controllers, there's also the SHDN# signal wired to a GPIO, it > ^^ >> should be driven high for the normal operation. > ^^ > As above '^' expression, you used the double space between words. > You should fix it. OK, since so many people seem to be offended by that, I'll fix it. Meanwhile, please comment on the patch itself. > Thanks, > Chanwoo Choi [...] MBR, Sergei