From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965545AbbLOWpf (ORCPT ); Tue, 15 Dec 2015 17:45:35 -0500 Received: from mga14.intel.com ([192.55.52.115]:42386 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932382AbbLOWpd (ORCPT ); Tue, 15 Dec 2015 17:45:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,434,1444719600"; d="scan'208";a="13831476" Subject: Re: [PATCH] net: fix uninitialized variable issue To: Eric Dumazet References: <20151215184617.11620.23369.stgit@tstruk-mobl1> <1450206129.8474.48.camel@edumazet-glaptop2.roam.corp.google.com> Cc: herbert@gondor.apana.org.au, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, freude@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, linux-crypto@vger.kernel.org From: Tadeusz Struk Message-ID: <5670973C.7030406@intel.com> Date: Tue, 15 Dec 2015 14:42:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450206129.8474.48.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2015 11:02 AM, Eric Dumazet wrote: > On Tue, 2015-12-15 at 10:46 -0800, Tadeusz Struk wrote: >> msg_iocb needs to be initialized on the recv/recvfrom path. >> Otherwise afalg will wrongly interpret it as an async call. >> >> Cc: stable@vger.kernel.org >> Reported-by: Harald Freudenberger >> Signed-off-by: Tadeusz Struk >> --- >> net/socket.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/net/socket.c b/net/socket.c >> index dd2c247..80ca820 100644 >> --- a/net/socket.c >> +++ b/net/socket.c >> @@ -1702,6 +1702,7 @@ SYSCALL_DEFINE6(recvfrom, int, fd, void __user *, ubuf, size_t, size, >> msg.msg_name = addr ? (struct sockaddr *)&address : NULL; >> /* We assume all kernel code knows the size of sockaddr_storage */ >> msg.msg_namelen = 0; >> + msg.msg_iocb = NULL; >> if (sock->file->f_flags & O_NONBLOCK) >> flags |= MSG_DONTWAIT; >> err = sock_recvmsg(sock, &msg, iov_iter_count(&msg.msg_iter), flags); >> > > Do not add "Cc: stable@vger.kernel.org" for networking patches, thanks > ( Documentation/networking/netdev-FAQ.txt ) > > Do you know when was this bug added ? > > Please add the > > Fixes: 12-digit-sha1 ("patch title") > It was added in this commit: 0345f93138b2 ("net: socket: add support for async operations") Thanks -- TS