From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932591AbbJPQZH (ORCPT ); Fri, 16 Oct 2015 12:25:07 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:63855 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbbJPQZE (ORCPT ); Fri, 16 Oct 2015 12:25:04 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Anup Patel , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Scott Branden , Pawel Moll , Ian Campbell , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Ray Jui , Vikram Prakash , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Sandeep Tripathy , Kumar Gala , Pramod KUMAR Subject: Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Date: Fri, 16 Oct 2015 18:24:21 +0200 Message-ID: <5673177.0QYFhMPCBq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444986537-28387-3-git-send-email-anup.patel@broadcom.com> References: <1444986537-28387-1-git-send-email-anup.patel@broadcom.com> <1444986537-28387-3-git-send-email-anup.patel@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:hApg7EzRQv4+xW0OUndC0pWdNXhG/cPBB95KqnuHs9UAQviaAzy ef1Wn0eZvlbJmwb16X0wTsvIty0hpTolnybbkiTQ1dr7joH4A9F9G81roeMV8ydzxI560f/ tYFgw5VD77zEMOulRzyo+0EBOqdlZR164mcyzajUn+zJ4tw2cfSMTXK+n1Y2pNckCya+CNO 9VwZZ8+EN9FtGb2nCEFDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:IvExalLALVw=:4SefvajFcvS96jectY8IRv pLyXki06a+2Gux8afeSPLJ5H07Mz39dZwPp82NegSZFXumq47VTe4gmMl/GlcJMpgfh6rZFJP YNMUR+5+6K8FRbPmGXSojxfwELTI8aKf78yqRbAJQ60Wj/ftGmQFjsurP10MnNpLtRiG/sHnO doKNqcR6aN5OrqkQt3cGEL6avbRGb8l41xcST9JoJ8wkE1hQzxe5c+Ip7WkHRpIds8t+9lQhh PVEltyor5nk8aR16b5sCaKxZ94aLZ+5py5nGLpkzIZgVtIck4Lw21G9K/eJeivPT+11OYS95/ dgpOsqRgJ4pxK1j8FShspLJlKacpiOTxGHeD+cNdvEDt/kQT/k38o8SmdAu5KOxqEjPH4CedU U3furG+1yfEOIqiSsecNu1ddAUmf+7q0hzkJzIQQdSVn51MWdcCmKAYuzReYeKlJRcUWsVvr8 VCKIJfhQw0oQWkgA0qMCR3qJ/dNp9vbhwIdznjWqEUJ9HsPKylAD58CIKlB3WT1QlCiLN2W1d trWobtTOV6x2CiQsm1G4bNQ60fFWt+31xIVPYj1JFcWrWWy9pQ6lQRuX9bwzmqN6slJru7xpI U4Ib/TgRCxVXpagyxPQtcAE40141CL0XW0hkLGdOYFFzyrNbhJSbLT+/WnEUHGfy3HGYAAPPn skbbFYMtAEEo0X50RnTc8IJII5lNtfrIVHivFsLH5+NxKgTyr5Gwlsu2aw6Tmo0qGidgvTPyF 0GxUVmIQvxVRL06y Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 16 October 2015 14:38:55 Anup Patel wrote: > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 3324281..a1b5819 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -393,7 +393,7 @@ config MTD_NAND_GPMI_NAND > > config MTD_NAND_BRCMNAND > tristate "Broadcom STB NAND controller" > - depends on ARM || MIPS > + depends on ARM || ARM64 || MIPS > help > Enables the Broadcom NAND controller driver. The controller was > originally designed for Set-Top Box but is used on various BCM7xxx, > -- > I think you also need this one: 8<----------- >>From 0ab7b2d32921b3f3da15274d8c3982ba1d54660f Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Thu, 4 Jun 2015 09:25:59 +0200 Subject: [PATCH] mtd: brcmnand depends on MTD_NAND MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed to be built without CONFIG_MTD_NAND, which results in a link error: drivers/built-in.o: In function `brcmnand_remove': coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release' drivers/built-in.o: In function `brcmnand_probe': coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident' coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail' This adds an explicit Kconfig dependency. Signed-off-by: Arnd Bergmann diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 289664089cf3..4b7e853ce35d 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -393,6 +393,7 @@ config MTD_NAND_GPMI_NAND config MTD_NAND_BRCMNAND tristate "Broadcom STB NAND controller" + depends on MTD_NAND depends on ARM || ARM64 || MIPS help Enables the Broadcom NAND controller driver. The controller was