From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932916AbbLRQUf (ORCPT ); Fri, 18 Dec 2015 11:20:35 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:56192 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932098AbbLRQUe (ORCPT ); Fri, 18 Dec 2015 11:20:34 -0500 Subject: Re: [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE To: Arnd Bergmann References: <1562989.nyG23Y3QQo@wuerfel> Cc: yalin wang , Jean Delvare , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Guenter Roeck Message-ID: <5674324E.6050908@roeck-us.net> Date: Fri, 18 Dec 2015 08:20:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1562989.nyG23Y3QQo@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/2015 06:52 AM, Arnd Bergmann wrote: > If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link: > > drivers/built-in.o: In function `sht15_crc8': > drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table' > > This adds a Kconfig 'select' statement, like all other users of > bitrev.h have it. > > Signed-off-by: Arnd Bergmann > Fixes: 33836ee98533 ("hwmon:change sht15_reverse()") Good catch. Applied. Thanks, Guenter > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 4a6e7c217329..60fb80bd353d 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN > config SENSORS_SHT15 > tristate "Sensiron humidity and temperature sensors. SHT15 and compat." > depends on GPIOLIB || COMPILE_TEST > + select BITREVERSE > help > If you say yes here you get support for the Sensiron SHT10, SHT11, > SHT15, SHT71, SHT75 humidity and temperature sensors. > >