From: Alex Elder <elder@riscstar.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, Yixun Lan <dlan@gentoo.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, heylenay@4d2.org,
inochiama@outlook.com, guodong@riscstar.com,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/6] clk: spacemit: set up reset auxiliary devices
Date: Mon, 12 May 2025 11:27:25 -0500 [thread overview]
Message-ID: <5674cfb0-fabe-4b58-98fd-8479c4d3ff79@riscstar.com> (raw)
In-Reply-To: <91afcfde275a28127ba0df962a9abf4d07ba6b8b.camel@pengutronix.de>
On 5/12/25 10:46 AM, Philipp Zabel wrote:
>>> so I'd assume the underlying device doesn't really care the id?
>>> but with different order of registration, it will result random id for the device
>> These things are identified in DTS files by their index values
>> defined in "spacemit,k1-syscon.h". If there is a need for the
>> assigned device ID to be consistent, I'm not aware of it. Can
>> you think of one? I think all that matters is that they're
>> unique, and this ensures that (for up to 2^32 PMICs).
> If there are multiple reset controllers and the driver can be unbound,
> it's trivial to provoke a collision by keeping one device bound and
> unbinding/binding the second one until next_id wraps.
> This could be fixed by using ida_alloc/free to manage the id.
>
> regards
> Philipp
OK thank you. I'll put together v9 of this series and will use
an IDA to set the device ID. Thanks again for the explanation.
-Alex
next prev parent reply other threads:[~2025-05-12 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 11:20 [PATCH v8 0/6] reset: spacemit: add K1 reset support Alex Elder
2025-05-09 11:20 ` [PATCH v8 1/6] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets Alex Elder
2025-05-09 11:20 ` [PATCH v8 2/6] soc: spacemit: create a header for clock/reset registers Alex Elder
2025-05-09 11:20 ` [PATCH v8 3/6] clk: spacemit: set up reset auxiliary devices Alex Elder
2025-05-12 13:54 ` Yixun Lan
2025-05-12 15:34 ` Alex Elder
2025-05-12 15:46 ` Philipp Zabel
2025-05-12 16:27 ` Alex Elder [this message]
2025-05-09 11:20 ` [PATCH v8 4/6] reset: spacemit: add support for SpacemiT CCU resets Alex Elder
2025-05-09 11:20 ` [PATCH v8 5/6] reset: spacemit: define three more CCUs Alex Elder
2025-05-09 11:20 ` [PATCH v8 6/6] riscv: dts: spacemit: add reset support for the K1 SoC Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5674cfb0-fabe-4b58-98fd-8479c4d3ff79@riscstar.com \
--to=elder@riscstar.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=guodong@riscstar.com \
--cc=heylenay@4d2.org \
--cc=inochiama@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®