From: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
Junaid Shahid <junaids@google.com>
Subject: Re: [PATCH] KVM/MMU: Combine flushing remote tlb in mmu_set_spte()
Date: Wed, 25 Jul 2018 14:22:54 +0800 [thread overview]
Message-ID: <56751e17-a271-1a73-026b-838e6b739420@gmail.com> (raw)
In-Reply-To: <1aaaecab-0e18-f504-5465-06db9d852cc5@redhat.com>
On 07/24/2018 10:35 PM, Paolo Bonzini wrote:
> On 24/07/2018 10:17, Tianyu Lan wrote:
>> mmu_set_spte() flushes remote tlbs for drop_parent_pte/drop_spte()
>> and set_spte() separately. This may introduce redundant flush. This
>> patch is to combine these flushes and check flush request after
>> calling set_spte().
>>
>> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> Looks good, but I'd like a second opinion. Guangrong, Junaid, can you
> review this?
>
It looks good to me.
Reviewed-by: Xiao Guangrong <xiaoguangrong@tencent.com>
BTW, the @intel box is not accessible to me now. ;)
prev parent reply other threads:[~2018-07-25 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 8:17 Tianyu Lan
2018-07-24 14:35 ` Paolo Bonzini
2018-07-25 2:26 ` Junaid Shahid
2018-07-25 2:35 ` Tianyu Lan
2018-07-25 6:22 ` Xiao Guangrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56751e17-a271-1a73-026b-838e6b739420@gmail.com \
--to=xiaoguangrong.eric@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=hpa@zytor.com \
--cc=junaids@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®