mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
	<pavel@ucw.cz>, <rdunlap@infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-leds@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention
Date: Fri, 12 Apr 2019 06:50:32 -0500	[thread overview]
Message-ID: <5675ac20-6db2-34ea-938a-01f0076b87e7@ti.com> (raw)
In-Reply-To: <20190412000707.70f8319f@nic.cz>

Marek

On 4/11/19 5:07 PM, Marek Behun wrote:
> Hi Dan,
> this probaly was discussed, but I did not follow brightness model
> discussions:
> what will happen if I set yellow by writing into yellow mode
> brightness, and then orange by writing orange model brightness?
> Will the resulting color be a mix of yellow and orange, or will the
> orange overwrite the yellow setting?
> 

This was not discussed and is a good question.  If you write the yellow mode for a group of
LEDs then yellow would be produced for the brightness requested.

If orange is then requested then orange should be displayed at the brightness level requested.
So yes the orange will over write the yellow.

The next question is if the absolute colors are written does it produce the same behavior?

So if you have yellow and write to the red should the red LED brightness be modified or should the
color switch to red?
And if the red LED is on and the blue LED is written should the color switch to blue or should the blue and red LEDs be mixed together?

This is tricky as the user space can write the individual absolute colors and mix the LEDs to produce varying
colors.  But the behavior writing the brightness models are different.

I would almost prefer that the user space reads the available absolute LED colors and creates the devices supported color palette and write the absolute LED colors only.  But this violates the requirements asked for.

Dan

> Marek
> 

  reply	other threads:[~2019-04-12 11:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 19:38 [PATCH v2 0/7] Multicolor Framework Dan Murphy
2019-04-11 19:38 ` [PATCH v2 1/7] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-04-11 19:38 ` [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-04-11 22:07   ` Marek Behun
2019-04-12 11:50     ` Dan Murphy [this message]
2019-04-12 19:10       ` Jacek Anaszewski
2019-04-12 22:02         ` Dan Murphy
2019-04-13  9:54           ` Jacek Anaszewski
2019-04-12 18:14     ` Jacek Anaszewski
2019-04-12 18:46       ` Dan Murphy
2019-04-12 19:24         ` Jacek Anaszewski
2019-04-11 19:38 ` [PATCH v2 3/7] documention: leds: Add multicolor class documentation Dan Murphy
2019-04-11 19:38 ` [PATCH v2 4/7] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-04-11 19:38 ` [PATCH v2 5/7] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-04-11 19:38 ` [PATCH v2 6/7] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-04-11 20:54   ` Dan Murphy
2019-04-29 21:15   ` Rob Herring
2019-04-11 19:38 ` [PATCH v2 7/7] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-04-11 20:53   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5675ac20-6db2-34ea-938a-01f0076b87e7@ti.com \
    --to=dmurphy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®