From: Milo Kim <milo.kim@ti.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: <kernel-janitors@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: lp8788: constify regulator_ops structures
Date: Mon, 21 Dec 2015 08:20:20 +0900 [thread overview]
Message-ID: <567737B4.40904@ti.com> (raw)
In-Reply-To: <1450539802-22570-1-git-send-email-Julia.Lawall@lip6.fr>
On 20/12/15 00:43, Julia Lawall wrote:
> The regulator_ops structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Milo Kim <milo.kim@ti.com>
>
> ---
> drivers/regulator/lp8788-buck.c | 4 ++--
> drivers/regulator/lp8788-ldo.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/lp8788-buck.c b/drivers/regulator/lp8788-buck.c
> index a97bed9..ec46290 100644
> --- a/drivers/regulator/lp8788-buck.c
> +++ b/drivers/regulator/lp8788-buck.c
> @@ -344,7 +344,7 @@ static unsigned int lp8788_buck_get_mode(struct regulator_dev *rdev)
> REGULATOR_MODE_FAST : REGULATOR_MODE_NORMAL;
> }
>
> -static struct regulator_ops lp8788_buck12_ops = {
> +static const struct regulator_ops lp8788_buck12_ops = {
> .list_voltage = regulator_list_voltage_table,
> .map_voltage = regulator_map_voltage_ascend,
> .set_voltage_sel = lp8788_buck12_set_voltage_sel,
> @@ -357,7 +357,7 @@ static struct regulator_ops lp8788_buck12_ops = {
> .get_mode = lp8788_buck_get_mode,
> };
>
> -static struct regulator_ops lp8788_buck34_ops = {
> +static const struct regulator_ops lp8788_buck34_ops = {
> .list_voltage = regulator_list_voltage_table,
> .map_voltage = regulator_map_voltage_ascend,
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> diff --git a/drivers/regulator/lp8788-ldo.c b/drivers/regulator/lp8788-ldo.c
> index 30e28b1..cbfd358 100644
> --- a/drivers/regulator/lp8788-ldo.c
> +++ b/drivers/regulator/lp8788-ldo.c
> @@ -170,7 +170,7 @@ static int lp8788_ldo_enable_time(struct regulator_dev *rdev)
> return ENABLE_TIME_USEC * val;
> }
>
> -static struct regulator_ops lp8788_ldo_voltage_table_ops = {
> +static const struct regulator_ops lp8788_ldo_voltage_table_ops = {
> .list_voltage = regulator_list_voltage_table,
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> .get_voltage_sel = regulator_get_voltage_sel_regmap,
> @@ -180,7 +180,7 @@ static struct regulator_ops lp8788_ldo_voltage_table_ops = {
> .enable_time = lp8788_ldo_enable_time,
> };
>
> -static struct regulator_ops lp8788_ldo_voltage_fixed_ops = {
> +static const struct regulator_ops lp8788_ldo_voltage_fixed_ops = {
> .list_voltage = regulator_list_voltage_linear,
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,
>
next prev parent reply other threads:[~2015-12-20 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 15:43 Julia Lawall
2015-12-20 23:20 ` Milo Kim [this message]
2015-12-23 0:09 ` Applied "regulator: lp8788: constify regulator_ops structures" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567737B4.40904@ti.com \
--to=milo.kim@ti.com \
--cc=Julia.Lawall@lip6.fr \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome