From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbbLVHWo (ORCPT ); Tue, 22 Dec 2015 02:22:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:42506 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbbLVHWn (ORCPT ); Tue, 22 Dec 2015 02:22:43 -0500 Subject: Re: [PATCH v3 26/77] ncr5380: Fix NCR5380_transfer_pio() result To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" References: <20151222011737.980475848@telegraphics.com.au> <20151222011745.091589071@telegraphics.com.au> From: Hannes Reinecke Message-ID: <5678FA40.4040309@suse.de> Date: Tue, 22 Dec 2015 08:22:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011745.091589071@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > According to the SCSI-2 draft revision 10L, atari_NCR5380.c is correct > when it says that the phase lines are valid up until ACK is negated > following the transmission of the last byte in MESSAGE IN phase. This is > true for all information transfer phases, from target to initiator. > > Sample the phase bits in STATUS_REG so that NCR5380_transfer_pio() can > return the correct result. The return value is presently unused (perhaps > because of bugs like this) but this change at least fixes the caller's > phase variable, which is passed by reference. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 12 +++++++++--- > drivers/scsi/atari_NCR5380.c | 11 ++++++----- > 2 files changed, 15 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)