From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbbLVH0H (ORCPT ); Tue, 22 Dec 2015 02:26:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:42702 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbbLVH0E (ORCPT ); Tue, 22 Dec 2015 02:26:04 -0500 Subject: Re: [PATCH v3 30/77] ncr5380: Add missing break after case MESSAGE_REJECT To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" References: <20151222011737.980475848@telegraphics.com.au> <20151222011746.205576191@telegraphics.com.au> From: Hannes Reinecke Message-ID: <5678FB0A.9020900@suse.de> Date: Tue, 22 Dec 2015 08:26:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011746.205576191@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > MESSAGE REJECT does not imply DISCONNECT: the target is about to enter > MESSAGE IN or MESSAGE OUT phase. > > This bug fix comes from atari_NCR5380.c. Unfortunately it never made it > into the original NCR5380.c core driver. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux/drivers/scsi/NCR5380.c > =================================================================== > --- linux.orig/drivers/scsi/NCR5380.c 2015-12-22 12:16:16.000000000 +1100 > +++ linux/drivers/scsi/NCR5380.c 2015-12-22 12:16:17.000000000 +1100 > @@ -1990,6 +1990,7 @@ static void NCR5380_information_transfer > default: > break; > } > + break; > case DISCONNECT:{ > /* Accept message by clearing ACK */ > NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE); > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)