From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbbLVHrd (ORCPT ); Tue, 22 Dec 2015 02:47:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:43657 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbbLVHrb (ORCPT ); Tue, 22 Dec 2015 02:47:31 -0500 Subject: Re: [PATCH v3 51/77] ncr5380: Remove command list debug code To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , Russell King , linux-arm-kernel@lists.infradead.org References: <20151222011737.980475848@telegraphics.com.au> <20151222011751.836236766@telegraphics.com.au> From: Hannes Reinecke Message-ID: <56790011.4040302@suse.de> Date: Tue, 22 Dec 2015 08:47:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011751.836236766@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Some NCR5380 hosts offer a .show_info method to access the contents of > the various command list data structures from a procfs file. When NDEBUG > is set, the same information is sent to the console during EH. > > The two core drivers, atari_NCR5380.c and NCR5380.c differ here. Because > it is just for debugging, the easiest way to fix the discrepancy is > simply remove this code. > > The only remaining users of NCR5380_show_info() and NCR5380_write_info() > are drivers that define PSEUDO_DMA. The others have no use for the > .show_info method, so don't initialize it. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 70 ++------------------------------ > drivers/scsi/arm/oak.c | 2 > drivers/scsi/atari_NCR5380.c | 94 +------------------------------------------ > drivers/scsi/atari_scsi.c | 2 > drivers/scsi/g_NCR5380.c | 1 > drivers/scsi/sun3_scsi.c | 2 > 6 files changed, 9 insertions(+), 162 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)