From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbbLVHz0 (ORCPT ); Tue, 22 Dec 2015 02:55:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:43991 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbbLVHzY (ORCPT ); Tue, 22 Dec 2015 02:55:24 -0500 Subject: Re: [PATCH v3 57/77] ncr5380: Use standard list data structure To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , Russell King , linux-arm-kernel@lists.infradead.org References: <20151222011737.980475848@telegraphics.com.au> <20151222011753.525503258@telegraphics.com.au> From: Hannes Reinecke Message-ID: <567901E9.70006@suse.de> Date: Tue, 22 Dec 2015 08:55:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011753.525503258@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > The NCR5380 drivers have a home-spun linked list implementation for > scsi_cmnd structs that uses cmd->host_scribble as a 'next' pointer. Adopt > the standard list_head data structure and list operations instead. Remove > the eh_abort_handler rather than convert it. Doing the conversion would > only be churn because the existing EH handlers don't work and get replaced > in a subsequent patch. > > Signed-off-by: Finn Thain > > --- > > Changed since v2: > - Fix NULL pointer dereference in NCR5380_reselect() when SUPPORT_TAGS is > enabled in the atari_NCR5380.c core driver. > Well, using ->host_scribble allows for an easy check on the midlayer if a command has been properly released by the LLDD. But that's just a side-note. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)