From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbbLVIE1 (ORCPT ); Tue, 22 Dec 2015 03:04:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:44479 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580AbbLVIEZ (ORCPT ); Tue, 22 Dec 2015 03:04:25 -0500 Subject: Re: [PATCH v3 67/77] ncr5380: Cleanup comments To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" References: <20151222011737.980475848@telegraphics.com.au> <20151222011756.245494676@telegraphics.com.au> From: Hannes Reinecke Message-ID: <56790407.70305@suse.de> Date: Tue, 22 Dec 2015 09:04:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011756.245494676@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > The CVS revision log is not nearly as useful as the history/history.git > repo, so remove it. Roman's commentary at the top of his driver repeats > the same information elsewhere in the file so remove it. Also remove > some other redundant or obsolete comments. > > Both the driver and the datasheets confusingly refer to a DMA access > for a SCSI WRITE command as a "DMA write". Similarly a SCSI READ command > is called a "DMA read". This is the opposite of the usual convention. > Thankfully, the chip documentation and driver code also use "DMA send" and > "DMA receive", so adopt this terminology. > > This removes some unimportant discrepancies between the two core driver > forks so that 'diff' can be used to reveal the important ones, to > facilitate reunification. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 154 ++++++++++--------------------------------- > drivers/scsi/atari_NCR5380.c | 97 +++------------------------ > 2 files changed, 48 insertions(+), 203 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)