From: "Jan Beulich" <JBeulich@suse.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: "Borislav Petkov" <bp@suse.de>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86/ucode: replace redundant string literals
Date: Tue, 22 Dec 2015 08:40:43 -0700 [thread overview]
Message-ID: <56797D0B02000078000C24EC@prv-mh.provo.novell.com> (raw)
This doesn't just eliminate needless redundancy (plus avoid a possible
disconnect if one string instance gets changed without the other(s)),
but also eliminates a warning some gcc versions emit ("array access
beyond array bounds", observed with 4.3.4) in the 32-bit case.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
arch/x86/kernel/cpu/microcode/core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- 4.4-rc6/arch/x86/kernel/cpu/microcode/core.c
+++ 4.4-rc6-x86-ucode-early-string/arch/x86/kernel/cpu/microcode/core.c
@@ -83,13 +83,11 @@ static bool __init check_loader_disabled
{
#ifdef CONFIG_X86_32
const char *cmdline = (const char *)__pa_nodebug(boot_command_line);
- const char *opt = "dis_ucode_ldr";
- const char *option = (const char *)__pa_nodebug(opt);
+ const char *option = (const char *)__pa_nodebug(__setup_str_disable_loader);
bool *res = (bool *)__pa_nodebug(&dis_ucode_ldr);
-
#else /* CONFIG_X86_64 */
const char *cmdline = boot_command_line;
- const char *option = "dis_ucode_ldr";
+ const char *option = __setup_str_disable_loader;
bool *res = &dis_ucode_ldr;
#endif
next reply other threads:[~2015-12-22 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 15:40 Jan Beulich [this message]
2015-12-22 17:07 ` Borislav Petkov
2015-12-22 17:20 ` Jan Beulich
2015-12-22 18:14 ` Borislav Petkov
2015-12-23 10:06 ` Jan Beulich
2015-12-23 10:10 ` Borislav Petkov
2015-12-23 10:11 ` Jan Beulich
2016-01-05 20:44 ` [PATCH] x86/microcode: Remove redundant __setup() param parsing Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56797D0B02000078000C24EC@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®