mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Andrew Lunn <andrew@lunn.ch>, Quentin Schulz <foss+kernel@0leil.net>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Heiko Stuebner <heiko.stuebner@cherry.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: fix Ethernet PHY not found on PX30 Cobra
Date: Mon, 2 Feb 2026 15:02:08 +0100	[thread overview]
Message-ID: <567d6404-2a71-43ad-8ba7-5053fe1576bd@cherry.de> (raw)
In-Reply-To: <33d3bdd5-0fed-41f6-8b8c-9690e7665346@lunn.ch>

Hi Andrew,

On 2/2/26 2:52 PM, Andrew Lunn wrote:
> On Mon, Feb 02, 2026 at 11:27:25AM +0100, Quentin Schulz wrote:
>> From: Quentin Schulz <quentin.schulz@cherry.de>
>>
>> When not passing the PHY ID with an ethernet-phy-idX.Y compatible
>> property, the MDIO bus will attempt to auto-detect the PHY by reading
>> its registers and then probing the appropriate driver. For this to work,
>> the PHY needs to be in a working state.
>>
>> Unfortunately, the net subsystem doesn't control the PHY reset GPIO when
>> attempting to auto-detect the PHY. This means the PHY needs to be in a
>> working state when entering the Linux kernel. This historically has been
>> the case for this device, but only because the bootloader was taking
>> care of initializing the Ethernet controller even when not using it.
>> We're attempting to support the removal of the network stack in the
>> bootloader, which means the Linux kernel will be entered with the PHY
>> still in reset and now Ethernet doesn't work anymore.
>>
>> The devices in the field only ever had a TI DP83825, so let's simply
>> bypass the auto-detection mechanism entirely by passing the appropriate
>> PHY IDs via the compatible.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: bb510ddc9d3e ("arm64: dts: rockchip: add px30-cobra base dtsi and board variants")
>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> What is the justification for stable?
> 

Bootloader without network stack = no network in Linux.

Cheers,
Quentin

  reply	other threads:[~2026-02-02 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 10:27 [PATCH 0/2] arm64: dts: rockchip: fix Ethernet PHY on Theobroma PX30 devices Quentin Schulz
2026-02-02 10:27 ` [PATCH 1/2] arm64: dts: rockchip: fix Ethernet PHY not found on PX30 Cobra Quentin Schulz
2026-02-02 13:52   ` Andrew Lunn
2026-02-02 14:02     ` Quentin Schulz [this message]
2026-02-02 14:55       ` Andrew Lunn
2026-02-02 16:31         ` Quentin Schulz
2026-02-02 10:27 ` [PATCH 2/2] arm64: dts: rockchip: fix Ethernet PHY not found on PX30 Ringneck Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567d6404-2a71-43ad-8ba7-5053fe1576bd@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=foss+kernel@0leil.net \
    --cc=heiko.stuebner@cherry.de \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®