From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372AbdLOMah (ORCPT ); Fri, 15 Dec 2017 07:30:37 -0500 Received: from mga09.intel.com ([134.134.136.24]:53557 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755222AbdLOMac (ORCPT ); Fri, 15 Dec 2017 07:30:32 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,404,1508828400"; d="scan'208";a="3038994" Subject: Re: [PATCH 1/9] ASoC: Intel: Fix Kconfig with top-level selector To: Takashi Iwai Cc: alsa-devel@alsa-devel.org, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org References: <20171215004451.30800-1-pierre-louis.bossart@linux.intel.com> <20171215004451.30800-2-pierre-louis.bossart@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <567e85e3-2906-86c8-9cd1-6210f811bd73@linux.intel.com> Date: Fri, 15 Dec 2017 06:30:28 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/17 5:07 AM, Takashi Iwai wrote: > On Fri, 15 Dec 2017 01:44:43 +0100, > Pierre-Louis Bossart wrote: >> >> +config SND_SOC_ACPI_INTEL_MATCH >> + tristate >> + depends on X86 && ACPI >> + select SND_SOC_ACPI > > An item that is selected by others can only select, not depend. > The depends need to be put for the items that select this instead. Initially the code was config SND_SOC_ACPI_INTEL_MATCH tristate select SND_SOC_ACPI if ACPI I changed it to use depends to make some 0-day reports go away, for some reason this option was selected with ARCH=mn10300 and generated warnings. I don't quite understand how that happened since X86 and ACPI are clear dependencies in the items which select this option... Vinod also added a similar pattern with +config SND_SOC_INTEL_SST_TOPLEVEL + bool "Intel ASoC SST drivers" + default y + depends on X86 || COMPILE_TEST + select SND_SOC_INTEL_MACH +menuconfig SND_SOC_INTEL_MACH + bool "Intel Machine drivers" depends on SND_SOC_INTEL_SST_TOPLEVEL Maybe that needs to be removed as well?