From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbeAaIHu (ORCPT ); Wed, 31 Jan 2018 03:07:50 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:42162 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133AbeAaIHr (ORCPT ); Wed, 31 Jan 2018 03:07:47 -0500 X-Google-Smtp-Source: AH8x225L+6QTnOwm94tY0QFV697LOG0lSEoH7VMguYMc2t/cbbmDIBCw+KYShtk95eG9SzdlWF4MDg== Subject: Re: [PATCH v8 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) To: Jacopo Mondi , laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com, geert@glider.be, hverkuil@xs4all.nl, mchehab@kernel.org, festevam@gmail.com, sakari.ailus@iki.fi, robh+dt@kernel.org, mark.rutland@arm.com, pombredanne@nexb.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1517306302-27957-1-git-send-email-jacopo+renesas@jmondi.org> <1517306302-27957-5-git-send-email-jacopo+renesas@jmondi.org> From: Sergei Shtylyov Message-ID: <567f779c-591c-4798-a8d0-504d25c439de@cogentembedded.com> Date: Wed, 31 Jan 2018 11:07:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517306302-27957-5-git-send-email-jacopo+renesas@jmondi.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 1/30/2018 12:58 PM, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart > Acked-by: Hans Verkuil > --- > arch/arm/boot/dts/r7s72100.dtsi | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi > index ab9645a..5fe62f9 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi [...] > @@ -667,4 +667,13 @@ > power-domains = <&cpg_clocks>; > status = "disabled"; > }; > + > + ceu: ceu@e8210000 { The DT spec dictates the generic node names should be used. For the R-Car VIN we use "video@...", hence I suggest that use the same here. > + reg = <0xe8210000 0x3000>; > + compatible = "renesas,r7s72100-ceu"; > + interrupts = ; > + clocks = <&mstp6_clks R7S72100_CLK_CEU>; > + power-domains = <&cpg_clocks>; > + status = "disabled"; > + }; > }; MBR, Sergei