From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884423EDABD for ; Mon, 2 Mar 2026 14:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461473; cv=none; b=gx5tG2gRk8SXbV2PsrvxMWymOJilUXVO4LJhg4E176WFsmlUGwpvYBECNVh9DUp/CzUgoRUfSb+Z79THG8T9Lo3z4hZDcJ84T6uWlql74cvPieJ1kmeALTWgROZWIs015mKXr0VL95srCjoDI+rFuAfhW5vN3JTm5o4RrC1YrKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461473; c=relaxed/simple; bh=VKVEsKkNDyQjSnTQnhOmZzdT1ohQEjAFOy/zAFmfDpk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fuIiw2Ly1VAxva753Dy9vbFBFcGielmnmR14udFFv2nHg0Xni5xYTqqSAvOFoInyjWqd/8hf6ECBGXZPbYMyNJ4JlUb+qWbQWSuGj7qAO2y0CId7O67Ip8Wj6G9uSoK7gDKv9q8vrufDoALrBXcdTbpqXe65jean93JQzPLiGp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CcOeScAj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jvRGXFqX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CcOeScAj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jvRGXFqX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772461471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yQruE7WU4QBS3d73QAD/6P/J4+XNtGXD0BMgqs54uZk=; b=CcOeScAjxApzgQDhbnRmYR+nGxpAlJbzmk79YyIT9NjHoxDblJuwIw0pWX2NtmuSpIqCLl rU1nrC+5KDjG4T5/yFnM3zYU/MDV5KsB6cRsGhceo7Fbho5pe9sibOPutZ+rFr1Oza1Rp2 T0+9WSsdaBS1fGcbLVumpBrrPowJWno= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-8rLd8GGePp2io0VrhguZRw-1; Mon, 02 Mar 2026 09:24:30 -0500 X-MC-Unique: 8rLd8GGePp2io0VrhguZRw-1 X-Mimecast-MFC-AGG-ID: 8rLd8GGePp2io0VrhguZRw_1772461469 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-65f75964cd2so6363465a12.0 for ; Mon, 02 Mar 2026 06:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772461469; x=1773066269; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=yQruE7WU4QBS3d73QAD/6P/J4+XNtGXD0BMgqs54uZk=; b=jvRGXFqXkJ1LyMASq0ts7eZ/cdWBHsYLSOHSjBi5LsRh1XllrXASY7eEE/GpQTioLz CY1WyllBx568WdP1t3jIAVEvDCAJeobpOtmPLXM6AuRh22hf3kAXYhSFNBtBlb5YERPW w4tUY3I8uBTPY/B9wMcXStgrkzMXFtRIQkHTYCixYuWK1w4IYUs4xxBruRNtd7uuYKIS hjE/QB47DHPUg1x/5PkNj7d05IAHXOnnBjFnffOzDNZRIn4OTXBKsupIn60BZSbSRe59 uvPKxtByiQSlZhSWdMIwHWtbkog9KgLs69XFmg1ptPaR5WJXzZcKRdsHuIhUNq643xgX daBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772461469; x=1773066269; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yQruE7WU4QBS3d73QAD/6P/J4+XNtGXD0BMgqs54uZk=; b=mRp5MT71veSjdRFQQPlUkki7TPp3lTS2ogZgCvzWlH/FHYK3D+5v+yA5cwzLyNsZ8F mKFckNKyYTm0nz61r9PQQdKt+6W2JlUwjPmBeoQHtSZSXFSXsOsXsPurB6K5dVyrKKLg EbrvyvzoDEjfzuonvywb9v0PWFyOhH3Ughr/sQjzvRioMgO23wC3wYWgSTgOd5jAolGI qZP25W588AjhcjoCma50PR/x/fZGciwoJn5/24uiPwlDrZwsphjV0N9WVTlG5GuqUP0l 8m1x5cveZZqRlwn3uB2jB3eopjUIZhYrgQ/DZI52ud3O/OJ4f2MBUPlSAN2iox7CWaVp B3hw== X-Gm-Message-State: AOJu0YzOfyWP35WM8AoH2P7QA2iQ5vW1PcOwOPlXNsowcTtawS9bqacw 1xb6I1wTFPwFkyf805liMfXEHdCOhKgt6CK5iuQHV2EXJWDqHfgJQ4R+nhP5/rKYQHlMXLVMD9J MdWCNddakQtqapu5hKMtnFbs1TZXk2BPsy9WMFt2KgI0N1T7M6D+zJSRozcrFKAUubQ== X-Gm-Gg: ATEYQzyfWyqNm0DFMMqi23oTUcMp3nWW3SjbUGQnBJxdaB06a+53k7Ht5016X8x7A3X y3NP6acWsbhpLb7rCn4SZfT6vXsn7KahxnuvdlSuyDrGT38BpR+DoKvSXU3mRcMAekNtnLsTPZd RBdfLrlMSMjISPUlv5JDFU7Uymlf/AYp4PZir+4kzWgIIigVuM/+ygDF6Dov2JBFlB9H4b+3bE3 wDFqR+F4xfKvLRAfi/TfTlrlkYAJyLj1Z05hDRhaTG/mPzcMoDThoFP+Hv0l9R7t+GFZgfHvki4 keQporoSW96noJchZDfWEtQzAjAZIqPjxishqRgRknl9RCTkiuPpZWZgA+nBiEHksLSaPs/WrNy ae3j+eS43VpmYXbyFGUGtg/FXOA96axKPIjAWM6G8QYVMAC0KdOdLQIE6r2GRKoLS7uBBkAQGWd w5ow05VrQdDR4I7do= X-Received: by 2002:a05:6402:354d:b0:658:bf9f:75be with SMTP id 4fb4d7f45d1cf-65fe2d730bbmr7219426a12.16.1772461469188; Mon, 02 Mar 2026 06:24:29 -0800 (PST) X-Received: by 2002:a05:6402:354d:b0:658:bf9f:75be with SMTP id 4fb4d7f45d1cf-65fe2d730bbmr7219409a12.16.1772461468767; Mon, 02 Mar 2026 06:24:28 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fac07b7c2sm3427619a12.31.2026.03.02.06.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 06:24:28 -0800 (PST) Message-ID: <567f7f5528643c3ee7e77cc49b7154edc424df72.camel@redhat.com> Subject: Re: [PATCH v6 12/16] sched: Add deadline tracepoints From: Gabriele Monaco To: Juri Lelli Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Masami Hiramatsu , Ingo Molnar , Peter Zijlstra , linux-trace-kernel@vger.kernel.org, Phil Auld , Tomas Glozar , Clark Williams , John Kacur Date: Mon, 02 Mar 2026 15:24:26 +0100 In-Reply-To: References: <20260225095122.80683-1-gmonaco@redhat.com> <20260225095122.80683-13-gmonaco@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, On Mon, 2026-03-02 at 15:15 +0100, Juri Lelli wrote: > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 4ca79ff58fca..b5bb2eb112bf 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -124,6 +124,10 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp); > > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp); > > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_enqueue_tp); > > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dequeue_tp); > > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_throttle_tp); > > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_replenish_tp); > > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_server_start_tp); > > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_server_stop_tp); >=20 > Don't we need to export sched_dl_update_tp as well? Right, we do. >=20 > > =C2=A0DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); > > =C2=A0DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); >=20 > ... >=20 > > @@ -1532,7 +1551,8 @@ static void update_curr_dl_se(struct rq *rq, stru= ct > > sched_dl_entity *dl_se, s64 > > =C2=A0 > > =C2=A0 if (!is_leftmost(dl_se, &rq->dl)) > > =C2=A0 resched_curr(rq); > > - } > > + } else > > + trace_sched_dl_update_tp(dl_se, cpu_of(rq), > > dl_get_type(dl_se, rq)); >=20 > This wants braces even if it's a single statement. Alright, will fix. Thanks, Gabriele