From: "André Almeida" <andrealmeid@collabora.com>
To: Colin King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Davidlohr Bueso <dave@stgolabs.net>,
Darren Hart <dvhart@infradead.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH][next] futex: fix assigned ret variable that is never read
Date: Wed, 1 Sep 2021 15:26:34 -0300 [thread overview]
Message-ID: <5682c44f-3a02-c2b1-25d3-36db34b00356@collabora.com> (raw)
In-Reply-To: <20210818131840.34262-1-colin.king@canonical.com>
Hi Colin,
Às 10:18 de 18/08/21, Colin King escreveu:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the check on the rt_waiter and top_waiter->pi_state is
> assigning an error return code to ret but this later gets re-assigned,
> hence the check is currently ineffective. I believe the original
> intent was to return -EINVAL rather than assign it to ret. Fix this.
>
> Addresses-Coverity: ("Unused value")
> Fixes: dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>> ---
Reviewed-by: André Almeida <andrealmeid@collabora.com>
next prev parent reply other threads:[~2021-09-01 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 13:18 Colin King
2021-09-01 18:26 ` André Almeida [this message]
2021-09-01 19:28 ` [tip: locking/urgent] futex: Return error code instead of assigning it without effect tip-bot2 for Colin Ian King
2021-09-01 20:24 ` [PATCH][next] futex: fix assigned ret variable that is never read Davidlohr Bueso
2021-09-02 20:14 ` [tip: locking/urgent] futex: Return error code instead of assigning it without effect tip-bot2 for Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5682c44f-3a02-c2b1-25d3-36db34b00356@collabora.com \
--to=andrealmeid@collabora.com \
--cc=colin.king@canonical.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®