From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6DB34B43D for ; Thu, 26 Mar 2026 05:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774501578; cv=none; b=ltu96yIWFVqyTZLgY+ck2XjMnf+5CPf57cKYyXciTnwQs9V4ioq3mIe1Y1XF475N2ic8LKe21afkHY4Ajv405LbwgI5AKP/B8VgeF3RpTX4VXF5Wh+M2tfoXaAgFwGUEaZffs1ZM5dwDlH/q8X2EUlngU3HO+tdz1Nvsqw68TQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774501578; c=relaxed/simple; bh=ObpuUhEncOlpi8q4Llh/6L0oowq9gECOdciNqUeKjLk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aUs+zkDT6YEPSNgSL0OHVGrsTJj8N3zjaHqbjemgq+ZowTOkFD0Eqf71B/9FqGk2X8rqjeTRavcsH+6xyCEGe+gkVXJ4kmS5wSOp9O20fTDhS6vcgKELWV8RbTFXNkwndlzdYb9Cg7v902qzNaOrkm+9FpslLkpOS1VuBO0M2E0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TwloJN/E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cwI1hLMv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TwloJN/E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cwI1hLMv" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PKfvnx1965109 for ; Thu, 26 Mar 2026 05:06:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kX/Q4tA/GGa5kkY3FZPPynvH5D47EXWFc+DBBlWPBDw=; b=TwloJN/EuipuqjgI ewx4ZWUoLxUzztkbX8sN4O8oWa/BefS83UksG56Ds8pzxKKR+CA2XsMKKwqOqSmh eiuDd3ojea2YJNNvzA1qhC3yC2Kj7G6xd4nLJk5DxcQhrSWb7HGiFeiyq1EKQ5qT wsZ1Xib8AuBQsGchz+JAQ3b5grWLJwMg8b/3RYd+2zRv4DV86uMTvfAyIDDL+Gvt aljeE66UU8CVMreOnssvgqueIsK8ZzD4A4gbebKZQVnv3IPWNDxJl/ubN+fgjlbO B0hl+kBG/o/rnEmvOimIr6LTNj6OAYbwoT/gs1qWH5AbU0014PcQWUyTQyoXV69I u7GWRw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4pymh94h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 05:06:16 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35c0abf427aso856527a91.0 for ; Wed, 25 Mar 2026 22:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774501576; x=1775106376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kX/Q4tA/GGa5kkY3FZPPynvH5D47EXWFc+DBBlWPBDw=; b=cwI1hLMvW0LbmNM9WMTrrVDey2DX8WdBvIpAGR8zMGGyGQe2v3xCVXzRwJvfI5UmF2 LdjASPbxkHEGpUsdvrhc0tHU3aAo947EBA/kWX8FDdLx8DwEppGfJCv+2lnW7Lc0pTio F5S6qMVsjNfkM+2tLJZ42CCFhFwq1BiGZi1sEos84R/auFqo0x6iUppw75SXsO1xM+HE imUficZlwvfQPqoUV4LFvo4KSFS9yolbmrEv4QgYhqJYK8jEkZr2UxZJX5FWgFwbhI8h u6v5lMfY2qkTlkOpWAR/N36Adl09ZB9KxJB6mmtJzF9r+/9aTVQbpIcRS5vYgob0PYUe kGsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774501576; x=1775106376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kX/Q4tA/GGa5kkY3FZPPynvH5D47EXWFc+DBBlWPBDw=; b=FMHK8pAAQXi36at2U500kHEZh4/kgKWH8uIT46WPoZWQXZS9MeEobTsvZRb0eRVto7 so0WZPRDv9eiYnQP7oBsUIiAU76N/0A9wpgy/3TyQshmFhaKIDH9t6LAyfttmmFsnYfu 5AKWLmFEQro/TIAmuiUAGmOeLdw45I/Xbg0XbNmQQxNKT0YDrQGEwfrGZH53Peu/G22w /IXfxohdY1A3p3i2G/1Zcs61j6nOdxDKlJPn9+IxAAPu7bv7ctROwtg8o9UMpaiIhQEh xCf5oDFFB8yBO/kh1E78VIZzZ4D5aTh6GAX3Uxoxnf3fbSFsClSGypwInvYIjNyeD3tV mKgg== X-Forwarded-Encrypted: i=1; AJvYcCUjWKT3p//yAEqG6NrCfIGlC3QMnEX3mvadWkAiEp+I6d6RdTvpt6g5prSjsvsYBkGFnSI/TmbF/9iE9Sg=@vger.kernel.org X-Gm-Message-State: AOJu0YzVFtWk/Aoo89UWzTPb/wndDVmTMpDjlE1cZqELZAc9esFPIt/u WyLFBA+41G9+4mQrEYvk5rx5DJwcfMAX1XK6/ifeD7uLDcb9AfVm/uDZDGRiwgCf8KkkgINMIJc atP/DAobChOyKIhk6V6Kn+bGqbW77ovYnx5kr8zoyV5g7tLZzv7en9NV/LTbCVDGaQB0= X-Gm-Gg: ATEYQzyeO7T0R7ouvjay5YSUyml61AB7G3tXXbbSgDCEZ/uZh+znSmwONlbKbl9Ws4a uzKgM0N/YaUKMCEJwYj8jyVA/clbOJ2DOorAOtL6g8TugAzOAuyxADpkWc5TBNyh/aUf+qhO/tp gvC/wPrwwgfl7uPklLVkbhD3XyTU70T0zy7NtQNoyzxE5X3r11tQ4vRERnfzVGsAnsAWE2wJVNF vsMEVO6csGRJv2osTXDBQtD+9W8aT6uRSypYN1UGPuhea8xdtxj2lWe9qKbNSSxn9bZD9Xk9H+Z uUPsM/1Z8F3Ha2XbJvv94PtBnwJjBA8mMdMMFcg4orKlYZJxb6Oaf6j44cuO3J84QNWkZAOD4yY 1yQ68WDQUfclIvXP6i0PvJo2zzJoyZoMGznQqS8Bwnm4dG+eis2pZ9A== X-Received: by 2002:a17:90b:4a03:b0:35b:9cd5:232e with SMTP id 98e67ed59e1d1-35c0dd95865mr5470203a91.29.1774501575458; Wed, 25 Mar 2026 22:06:15 -0700 (PDT) X-Received: by 2002:a17:90b:4a03:b0:35b:9cd5:232e with SMTP id 98e67ed59e1d1-35c0dd95865mr5470167a91.29.1774501574933; Wed, 25 Mar 2026 22:06:14 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.231]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c22d09429sm198541a91.17.2026.03.25.22.06.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 22:06:14 -0700 (PDT) Message-ID: <56860faf-3f74-daeb-3d19-a35243172317@oss.qualcomm.com> Date: Thu, 26 Mar 2026 10:36:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 3/9] media: iris: retrieve UBWC platform configuration Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue , Wangao Wang References: <20260125-iris-ubwc-v4-0-1ff30644ac81@oss.qualcomm.com> <20260125-iris-ubwc-v4-3-1ff30644ac81@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260125-iris-ubwc-v4-3-1ff30644ac81@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 96XKm2T_RQwmk1hZ82Gs-zX4VibZ8SFT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDAzNyBTYWx0ZWRfXy1fOpgVLkQpE d7BCLUIhdIU77Xwpi4+x0p0N5cZqtkrT8akguFyJwmBe77yTZBHBLqyj6gTiHkjSa8rWJBWsPUc 0a45dlZsxmqaPJxz3TUnhA8FxoAIqH7/EZEdgud2kskOVMgxgU+OOJ/b56P8jlHWRfbmD01o4h6 tGFe2h0qyhXX29vbWo3Tg03wN/0lumPxIPqxrSoo0zXckUUH5EmFb9AMbWU6hkOTDheZCZblxq4 WZNwXh/6dL/ac+v8wgFasN+NWvFKY+MFEdfL0stE0MM2Rd/9K1aQy7Xf/WERiZZA/Adv2UXyCV6 HgC5D6PCn6zHXGoq59Hd8ePA/2vvipBsXhW+K4xVAcsHafBy2HZ4RyQDJ1Y/ghnyjC9WsGFe372 1TvJpXHSwWckyR7EITe9Klsv0EUP/hxmz0mSG8ywX/iRMhnEGNPKEUyV5E6HT952qcrLnVQzyU3 7GblbbIRP3te9ulkPqw== X-Authority-Analysis: v=2.4 cv=SvedKfO0 c=1 sm=1 tr=0 ts=69c4bec8 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=n9i7a1ABM4vdrNuulSdbnA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=74htzXLwVZE36vefv0kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: 96XKm2T_RQwmk1hZ82Gs-zX4VibZ8SFT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_01,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260037 On 1/25/2026 5:00 PM, Dmitry Baryshkov wrote: > Specifying UBWC data in each driver doesn't scale and is prone to > errors. Request UBWC data from the central database in preparation to > using it through the rest of the driver. > > Reviewed-by: Bryan O'Donoghue > Reviewed-by: Konrad Dybcio > Reviewed-by: Dikshita Agarwal > Tested-by: Wangao Wang > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/Kconfig | 1 + > drivers/media/platform/qcom/iris/iris_core.h | 4 ++++ > drivers/media/platform/qcom/iris/iris_probe.c | 5 +++++ > 3 files changed, 10 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig > index 3c803a05305a..39b06de6c3e6 100644 > --- a/drivers/media/platform/qcom/iris/Kconfig > +++ b/drivers/media/platform/qcom/iris/Kconfig > @@ -5,6 +5,7 @@ config VIDEO_QCOM_IRIS > select V4L2_MEM2MEM_DEV > select QCOM_MDT_LOADER if ARCH_QCOM > select QCOM_SCM > + select QCOM_UBWC_CONFIG > select VIDEOBUF2_DMA_CONTIG > help > This is a V4L2 driver for Qualcomm iris video accelerator > diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h > index fb194c967ad4..d10a03aa5685 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.h > +++ b/drivers/media/platform/qcom/iris/iris_core.h > @@ -30,6 +30,8 @@ enum domain_type { > DECODER = BIT(1), > }; > > +struct qcom_ubwc_cfg_data; > + > /** > * struct iris_core - holds core parameters valid for all instances > * > @@ -52,6 +54,7 @@ enum domain_type { > * @resets: table of iris reset clocks > * @controller_resets: table of controller reset clocks > * @iris_platform_data: a structure for platform data > + * @ubwc_cfg: UBWC configuration for the platform > * @state: current state of core > * @iface_q_table_daddr: device address for interface queue table memory > * @sfr_daddr: device address for SFR (Sub System Failure Reason) register memory > @@ -95,6 +98,7 @@ struct iris_core { > struct reset_control_bulk_data *resets; > struct reset_control_bulk_data *controller_resets; > const struct iris_platform_data *iris_platform_data; > + const struct qcom_ubwc_cfg_data *ubwc_cfg; > enum iris_core_state state; > dma_addr_t iface_q_table_daddr; > dma_addr_t sfr_daddr; > diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c > index ddaacda523ec..492f85f518eb 100644 > --- a/drivers/media/platform/qcom/iris/iris_probe.c > +++ b/drivers/media/platform/qcom/iris/iris_probe.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > #include "iris_core.h" > #include "iris_ctrls.h" > @@ -244,6 +245,10 @@ static int iris_probe(struct platform_device *pdev) > > core->iris_platform_data = of_device_get_match_data(core->dev); > > + core->ubwc_cfg = qcom_ubwc_config_get_data(); > + if (IS_ERR(core->ubwc_cfg)) > + return PTR_ERR(core->ubwc_cfg); Afterthought: This change assumes that the presence of a UBWC config implies Iris UBWC support. However, some platforms (e.g. qcm2290) do have UBWC data defined at the SoC level but do not support UBWC in the video firmware, which could potentially surface during SYS_INIT if UBWC is advertised unconditionally, so this might be worth double‑checking. Thanks, Dikshita > + > ret = devm_request_threaded_irq(core->dev, core->irq, iris_hfi_isr, > iris_hfi_isr_handler, IRQF_TRIGGER_HIGH, "iris", core); > if (ret) >