From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbbFAOhB (ORCPT ); Mon, 1 Jun 2015 10:37:01 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:49599 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752846AbbFAOgv (ORCPT ); Mon, 1 Jun 2015 10:36:51 -0400 From: Arnd Bergmann To: Borislav Petkov Cc: Stephen Rothwell , Borislav Petkov , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Loc Ho Subject: Re: linux-next: build failure after merge of the edac-amd tree Date: Mon, 01 Jun 2015 16:36:20 +0200 Message-ID: <5689037.BqsIAc2Shz@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150601095127.GA21881@pd.tnic> References: <20150601170742.626210ef@canb.auug.org.au> <20150601095127.GA21881@pd.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:cYqEH6DaRpipWyZf76+Sa/jpAByVqU7dVP0i2qVNtBPwYWlp155 ZfH4/meXcby5Bco0DLDECPZ+XuexId+gEiCH0P1t2sX+yPs+7Roiw79tIAwiEpiYxJGpGMi 2Z3uDtNguMpgATbCxIx82o7OjTuh4TR74HG5OCYhfBArvg/VfZV//v6/bllVLtRJx1q0gii nW0as3/Ub82QiLzWnycBg== X-UI-Out-Filterresults: notjunk:1;V01:K0:+2TTS9LCNic=:BJ6/64Bwran/tzVVVOCmrK Sd6Y9jxHVHYg1wfbSwEW88Pl5kiSQDvv5lr+YBLPwUZHq+dQ51uPAFDPTmQx16cQ8oPvwUlG6 8uuwPiJtCKzpVL6nR5pZFF3yn378OMPPExmsZ+DXk0l3sk9EQ1hqTyOqWcVxU+Dn2VPDfjwnv Y9MZwq0DrhQiRF9X/nTMjhnHpiIpekGPTJAJg2xwInBr0ISM6Ak5ndujyqEAt2dHWe94CvfBL m7Jb45Zz4MHBWLQ3C+7lfOTJU1U0x06Hv0KcN5msGHppUFKoZMOsoqrI9gWJY8x2BAU9ZotXy +vvyr8SalEpUGERk6cQ6B6L6/c1mj/23llUzbs9B78D1FUpowkC/cHRZXM6JKA6LuMHzzrI83 NlHUM14OFONDlvMLrlN1351Xf+tw4Mz8jSUb8JwrvdFdWaEJXo7V86+CnD+Xyy5ldv8Ad+KQR 4caEbyGCPU3tx7I5fHCqJakSFkcqs9yasT7XVif9/s1q1lHGpu3kB2AK2IAtFWVvqa+XFYvQr IVd75VKXQ3ibVnuc5CmSnBc4oVHXiJmeE9BaWQAcXGCRhLFID8vFJdeMWznzN0zW15ZWvjmiW 9kawOmuQXde0IqylCbuI7yK15eGx1OUCNADvfzPtVRpAe7OX5OFc9B5/G76BVZsSyR63fcA+Y LKTkN88I9mWmoOBl5k5bIVr+EX3DfBe+Vxajg43kYiHpWZA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 01 June 2015 11:51:27 Borislav Petkov wrote: > On Mon, Jun 01, 2015 at 05:07:42PM +1000, Stephen Rothwell wrote: > > Hi Borislav, > > > > After merging the edac-amd tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/edac/xgene_edac.c: In function 'xgene_edac_pmd_l2c_version1': > > drivers/edac/xgene_edac.c:792:2: error: implicit declaration of function 'MIDR_VARIANT' [-Werror=implicit-function-declaration] > > switch (MIDR_VARIANT(read_cpuid_id())) { > > ^ > > drivers/edac/xgene_edac.c:792:2: error: implicit declaration of function 'read_cpuid_id' [-Werror=implicit-function-declaration] > > drivers/edac/xgene_edac.c:794:3: error: implicit declaration of function 'MIDR_REVISION' [-Werror=implicit-function-declaration] > > switch (MIDR_REVISION(read_cpuid_id())) { > > ^ > > drivers/edac/xgene_edac.c:797:4: error: implicit declaration of function 'read_cpuid' [-Werror=implicit-function-declaration] > > switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) { > > ^ > > drivers/edac/xgene_edac.c:797:40: error: 'REVIDR_EL1' undeclared (first use in this function) > > switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) { > > ^ > > drivers/edac/xgene_edac.c:790:37: note: in definition of macro 'REVIDR_MINOR_REV' > > #define REVIDR_MINOR_REV(revidr) ((revidr) & 0x00000007) > > ^ > > drivers/edac/xgene_edac.c:797:40: note: each undeclared identifier is reported only once for each function it appears in > > switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) { > > ^ > > drivers/edac/xgene_edac.c:790:37: note: in definition of macro 'REVIDR_MINOR_REV' > > #define REVIDR_MINOR_REV(revidr) ((revidr) & 0x00000007) > > ^ > > > > Caused by commit ("EDAC: Add APM X-Gene SoC EDAC driver"). You can't > > use COMPIlE_TEST for drivers that use arch specific APIs ... > > Yeah, the COMPIlE_TEST thing was not such a good idea, after all. > At least it should have been tested. Can we instead just kill the CPUID check? It has absolutely no business in a device driver like this, and the driver should be made to build fine on all architectures. Arnd