From: Quentin Monnet <qmo@kernel.org>
To: Hungyu Lin <dennylin0707@gmail.com>, bpf@vger.kernel.org
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH bpf-next] bpftool: avoid sign extension in unsigned enum JSON dumps
Date: Fri, 30 Oct 2026 11:26:31 +0100 [thread overview]
Message-ID: <5689c92c-318b-46cb-92d8-429fac9040c4@kernel.org> (raw)
In-Reply-To: <20261030090913.76944-1-dennylin0707@gmail.com>
2026-10-30 09:09 UTC+0000 ~ Hungyu Lin <dennylin0707@gmail.com>
> The BTF enum value is stored in a signed 32-bit field even when the
> enum is unsigned. Passing it directly to jsonw_uint_field(), which
> takes a uint64_t, sign-extends values with bit 31 set. For example,
> 0xffffffffU is printed as 18446744073709551615 instead of 4294967295
> by bpftool -j btf dump.
>
> Cast the value to __u32 before widening it, matching the conversion
> already used for plain-text output.
>
> Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Looks correct, thank you.
Acked-by: Quentin Monnet <qmo@kernel.org>
prev parent reply other threads:[~2026-10-30 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 9:09 Hungyu Lin
2026-10-30 10:26 ` Quentin Monnet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689c92c-318b-46cb-92d8-429fac9040c4@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dennylin0707@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®