From: Lee Duncan <lduncan@suse.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: emilne@redhat.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management
Date: Mon, 4 Jan 2016 11:45:27 -0800 [thread overview]
Message-ID: <568ACBD7.9010504@suse.com> (raw)
In-Reply-To: <56730BEB.2050007@suse.com>
On 12/17/2015 11:24 AM, Lee Duncan wrote:
> On 12/14/2015 05:55 PM, Martin K. Petersen wrote:
>>>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:
>>
>>>> I'm not opposed to having the module option if others (Martin?) feel
>>>> they need it, but generally I think it's better to keep things as
>>>> simple as possible. So, unless there are strong objections, I would
>>>> say no.
>>
>> Hannes> Agreeing with Ewan here.
>>
>> Hannes> I guess it's up to you to tell us whether you absolutely need a
>> Hannes> module parameter ...
>>
>> Still not a big ida fan but since the most people seem to be in favor of
>> this I guess I'll have to bite the bullet.
>>
>> I don't see much value in the module parameter since it will require
>> customers to tweak their configs and reproduce. Not worth the hassle.
>>
>
> Thank you Martin. I'll look at further cleaning up the host module, but
> I think this still much better than leaving the code as is.
>
James:
Do you need me to resubmit this patch now that it's accepted?
--
Lee Duncan
next prev parent reply other threads:[~2016-01-04 19:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 23:51 [PATCHv4 0/1] Update SCSI hosts to use ida for host number mgmt Lee Duncan
2015-10-07 23:51 ` [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management Lee Duncan
2015-10-14 12:22 ` Johannes Thumshirn
2015-10-14 13:55 ` James Bottomley
2015-10-14 18:34 ` Lee Duncan
2015-10-14 18:53 ` James Bottomley
2015-10-14 21:21 ` Lee Duncan
2015-10-15 5:52 ` Hannes Reinecke
2015-10-16 20:03 ` Lee Duncan
2015-10-16 20:14 ` Greg KH
2015-11-12 16:31 ` Lee Duncan
2015-11-13 21:54 ` Martin K. Petersen
2015-11-16 12:10 ` Hannes Reinecke
2015-11-16 21:47 ` Lee Duncan
2015-11-17 23:20 ` Martin K. Petersen
2015-12-10 21:48 ` Lee Duncan
2015-12-11 15:31 ` Ewan Milne
2015-12-13 19:16 ` Lee Duncan
2015-12-14 15:07 ` Ewan Milne
2015-12-14 15:29 ` Hannes Reinecke
2015-12-15 1:55 ` Martin K. Petersen
2015-12-17 19:24 ` Lee Duncan
2016-01-04 19:45 ` Lee Duncan [this message]
2016-01-05 23:53 ` Martin K. Petersen
2016-01-20 19:49 ` Lee Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568ACBD7.9010504@suse.com \
--to=lduncan@suse.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome