From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752360AbcAEMfl (ORCPT ); Tue, 5 Jan 2016 07:35:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40648 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbcAEMfi (ORCPT ); Tue, 5 Jan 2016 07:35:38 -0500 Subject: Re: [PATCH] scsi: mvsas: fix indenting on return error code To: Colin King , James Bottomley , "Martin K . Petersen" , Johannes Thumshirn , linux-scsi@vger.kernel.org References: <1451995000-9210-1-git-send-email-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Tomas Henzl Message-ID: <568BB898.8040403@redhat.com> Date: Tue, 5 Jan 2016 13:35:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1451995000-9210-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5.1.2016 12:56, Colin King wrote: > From: Colin Ian King > > The return code and error return is incorrectly indented which > may cause some confusion as it appears at first sight to be associated > with a device not ready error (with missing { } braces) rather than > a DEV_IS_GONE() failure. > > The incorrect indenting was introduced by commit > 0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support > for Task collector mode and fixed relative bugs") > > No functional change, just a minor code reformatting clean up. > > Signed-off-by: Colin Ian King Reviewed-by: Tomas Henzl Tomas