From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbcAGBdk (ORCPT ); Wed, 6 Jan 2016 20:33:40 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:33603 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752196AbcAGBdf (ORCPT ); Wed, 6 Jan 2016 20:33:35 -0500 X-AuditID: cbfee68d-f79646d000001355-30-568dc06df230 Message-id: <568DC068.6020602@samsung.com> Date: Thu, 07 Jan 2016 10:33:28 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Rameshwar Sahu , ulf.hansson@linaro.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com Cc: linux-mmc@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, Kaustubh Gondkar Subject: Re: [PATCH] mmc: host: arasan: sdhci-of-arasan: Remove no-hispd and no-cmd23 quirks for sdhci-arasan4.9a References: <1450877391-3029-1-git-send-email-rsahu@apm.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsWyRsSkQDf3QG+YweLPrBZ/Jx1jt5h/5Byr xaS1y5ktDv9byWSx6fE1VovLu+awWRz5389o8e5lhEXzmW9sFg1fGS1u7tjMbnF8bbgDj8fH 9Z8YPX7/msTocefaHjaPzUvqPd7vu8rm8XmTnMfez79ZAtijuGxSUnMyy1KL9O0SuDKWfr7H WrCUv2LfqTbWBsYOni5GTg4JAROJ729msULYYhIX7q1n62Lk4hASWMEoserfZkaYojnvd7NC JGYxSuzYv4IZwnnAKLH32R8gh4ODV0BL4sIkOZAGFgFVid/3PjGD2GwCOhLbvx1nArFFBcIk HqzbC7aNV0BQ4sfkeywgtohAocS7o7fBZjILvGCUWLn2CdhmYYFiiffvW9lAbCGBZkaJue/Z QWxOgWCJO7P+sYDsZRZQl5gyJRckzCwgL7F5zVuwORICnRwSXx+8ZIQ4SEDi2+RDYPUSArIS mw4wQzwmKXFwxQ2WCYxis5CcNAth6iwkUxcwMq9iFE0tSC4oTkovMtQrTswtLs1L10vOz93E CIzZ0/+e9e5gvH3A+hCjAAejEg/vg4zeMCHWxLLiytxDjKZAR0xklhJNzgcmhrySeENjMyML UxNTYyNzSzMlcV5FqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhhPn4kK2LPT5bRTkl7z W1bD3kfz/j2tf6HDFRp6y9ElYDnLHiEz/nVqa65zT+YPT5v6/V/kWW616frmh26ty2H/tnpa cUlvJLf/oRVH04+d8lRd/PjE3QU3Ns99F+92bH787v29kUyHYqX57n7cw2pdN/mOm5Te78sa d47uvKVTfzRsbZO69kJjJZbijERDLeai4kQAO04AhNQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoG7Ogd4wg+XXbSz+TjrGbjH/yDlW i0lrlzNbHP63ksli0+NrrBaXd81hszjyv5/R4t3LCIvmM9/YLBq+Mlrc3LGZ3eL42nAHHo+P 6z8xevz+NYnR4861PWwem5fUe7zfd5XN4/MmOY+9n3+zBLBHNTDaZKQmpqQWKaTmJeenZOal 2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCdqaRQlphTChQKSCwuVtK3wzQhNMRN 1wKmMULXNyQIrsfIAA0krGHMWPr5HmvBUv6KfafaWBsYO3i6GDk5JARMJOa8380KYYtJXLi3 nq2LkYtDSGAWo8SO/SuYIZwHjBJ7n/0Bcjg4eAW0JC5MkgNpYBFQlfh97xMziM0moCOx/dtx JhBbVCBM4sG6vWBDeQUEJX5MvscCYosIFEq8O3obbCazwAtGiZVrnzCCJIQFiiXev29lA7GF BJoZJea+ZwexOQWCJe7M+scCspdZQF1iypRckDCzgLzE5jVvmScwAl2JsGIWQtUsJFULGJlX MUqkFiQXFCel5xrmpZbrFSfmFpfmpesl5+duYgSnhWdSOxgP7nI/xCjAwajEw9uR1hsmxJpY VlyZe4hRgoNZSYRXQxgoxJuSWFmVWpQfX1Sak1p8iNEUGAYTmaVEk/OBKSuvJN7Q2MTMyNLI 3NDCyNhcSZy39lJkmJBAemJJanZqakFqEUwfEwenVAOjUZrmV1XJ/curnibu+uuynNVUtrOU 7/vRz2KWtSKKwfd1upQuhyha2E0/xtfUZxH8+unlvY6WFuviLodYm+zduHxn9L1tPLtvfoq0 Fkw4X+aR2ZutPenvvL4q82tVtdb5s579FAlUn6WU/u/pDPbzE+4UMBmVbDjQPfuRsaPQWc63 5U+UBHKUWIozEg21mIuKEwHWMBQ0IQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/05/2016 07:25 PM, Rameshwar Sahu wrote: > Hi Ulf, > > On Wed, Dec 23, 2015 at 6:59 PM, Rameshswar Prasad Sahu wrote: >> From: Rameshwar Prasad Sahu >> >> The Arason SD host controller supports set block count command (cmd23) >> and high speed mode. This patch re-enable both of these features that >> was disabled. For device that doesn't support high speed, it should >> configure its capability register accordingly instead disables it >> explicitly. >> >> Signed-off-by: Rameshwar Prasad Sahu >> --- >> drivers/mmc/host/sdhci-of-arasan.c | 5 ----- >> 1 files changed, 0 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c >> index 75379cb..5d9fdb3 100644 >> --- a/drivers/mmc/host/sdhci-of-arasan.c >> +++ b/drivers/mmc/host/sdhci-of-arasan.c >> @@ -172,11 +172,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev) >> goto clk_disable_all; >> } >> >> - if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) { >> - host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> - host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; I'm not sure what's correct since i didn't have any information for arasan. But in case of exynos, SDHCI_QUIRK_NO_HISPD_BIT is used because that bit is used as other purpose. If your SoC is not used anymore, i think this patch looks good. Best Regards, Jaehoon Chung >> - } >> - >> sdhci_get_of_property(pdev); >> pltfm_host = sdhci_priv(host); >> pltfm_host->priv = sdhci_arasan; >> -- >> 1.7.1 >> > > Any comment on this patch ?? > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >